[vcpkg manifests] fix some issues #12227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219
approved these changes
Jul 2, 2020
JackBoosY
added
category:vcpkg-bug
BillyONeal
approved these changes
Jul 3, 2020
BillyONeal
approved these changes
Jul 3, 2020
BillyONeal
requested changes
Jul 6, 2020
strega-nil
added
the
info:manifests
strega-nil
changed the title
BillyONeal
approved these changes
Jul 7, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
approved these changes
Jul 7, 2020
Neumann-A
reviewed
Jul 7, 2020
ras0219-msft
approved these changes
Jul 8, 2020
| @@ -39,15 +40,14 @@ Package collections to check for conflicts: | |||
| + [Packages search](https://pkgs.org/) | |||
|
|
|||
| #### Version | |||
| The port version. | |||
| The library version. | |||
|
|
|||
| This field is an alphanumeric string that may also contain `.`, `_`, or `-`. No attempt at ordering versions is made; all versions are treated as bit strings and are only evaluated for equality. | |||
There was a problem hiding this comment.
We may want to remove "No attempt at ordering versions is made" in preparation for adding versioning.
Neumann-A
reviewed
Jul 8, 2020
Neumann-A
reviewed
Jul 8, 2020
BillyONeal
approved these changes
Jul 9, 2020
additionally, I accidentally changed zlib, so change that back
ras0219-msft
approved these changes
Jul 9, 2020
Co-authored-by: Robert Schumacher <[email protected]>
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
Jul 10, 2020
Fixes googleapis#4487 The flag was implemented by Microsoft in microsoft/vcpkg#12227, thanks to @strega-nil! I believe we were seeing this flake not because of multiple installs happening at once, but rather because the machines that run our docker tests were sometimes overloaded and running very slow and thus it sometimes took more than 1.5 sec to acquire the lock. This is just a hypothesis. But regardless, we're now passing `--x-wait-for-lock` to all of our `vcpkg install` invocations to avoid these flakes.
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Fixes microsoft#12190 Fixes microsoft#12208 Fixes microsoft#12234 Fixes microsoft#12286 Fixes microsoft#12315 Fixes microsoft#12186 Fixes microsoft#12331 Fixes googleapis/google-cloud-cpp#4487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12190
Fixes #12208
Fixes #12234
Fixes #12286
Fixes #12315
Fixes #12186
Fixes #12331
Fixes googleapis/google-cloud-cpp#4487
cc @linquize @petersteneteg