Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Format the C++ in CI #11655

Merged
merged 3 commits into from
Jul 6, 2020
Merged

[vcpkg] Format the C++ in CI #11655

merged 3 commits into from
Jul 6, 2020

Conversation

strega-nil
Copy link
Contributor

No description provided.

BillyONeal
BillyONeal approved these changes May 29, 2020
View reviewed changes
@strega-nil strega-nil added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels May 29, 2020
@strega-nil
Copy link
Contributor Author

This should fail CI, but we need to add clang-format!

@BillyONeal BillyONeal added the depends:vm-update PR contains changes to the VM provisioning scripts label May 30, 2020
@strega-nil
Copy link
Contributor Author

@BillyONeal fwiw, this checks on Linux, not Windows; so we'd need clang-format on the Linux boxes (probably through https://apt.llvm.org)

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Jun 11, 2020
@BillyONeal
[llvm] Add LLVM installed by Visual Studio for potential consumption …
1079797 
…in a future triplet.

Also unblocks microsoft#11655 by getting clang-format on the boxes.
BillyONeal
BillyONeal approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but still needs VM update to take the provision-image.ps1 change.

@strega-nil strega-nil mentioned this pull request Jun 26, 2020
Merged
8 tasks
@strega-nil strega-nil force-pushed the format branch 3 times, most recently from 118d00f to 2d809ee Compare June 26, 2020 19:45
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Jun 30, 2020
@BillyONeal
[vcpkg] Add LLVM 10 to Windows CI machines for microsoft#11655
f313886
BillyONeal added a commit that referenced this pull request Jul 1, 2020
@BillyONeal
[vcpkg] VM Update (#12176)
532db1d 
* [qt5] Add more dependent Linux packages for #11596

* [vcpkg] Add LLVM 10 to Windows CI machines for #11655

* [vcpkg] Add missing Param block to InstallLLVM function.

* [vcpkg] Add throw after all Write-Error calls for consistency with #12172
@BillyONeal BillyONeal removed the depends:vm-update PR contains changes to the VM provisioning scripts label Jul 1, 2020
@strega-nil strega-nil force-pushed the format branch 4 times, most recently from 482e6df to 7828476 Compare July 6, 2020 19:10
@strega-nil strega-nil merged commit 6a41626 into microsoft:master Jul 6, 2020
@strega-nil strega-nil deleted the format branch July 16, 2020 17:45
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@strega-nil
[vcpkg] Format the C++ in CI (microsoft#11655)
345f3c1 
* [vcpkg] Format the C++ in the CI

* format the C++

* CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strega-nil @BillyONeal @NancyLi1013 @JackBoosY