Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg ci] add macos scripts to vcpkg repo #12172

Merged
merged 3 commits into from
Jul 1, 2020
Merged

[vcpkg ci] add macos scripts to vcpkg repo #12172

merged 3 commits into from
Jul 1, 2020

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Jun 30, 2020 •
edited
Loading

cc @BillyONeal

Still to do: add docs!

BillyONeal
BillyONeal approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the bits I mentioned here maybe deserve to be a subsequent PR, so IMO OK to merge as is (insofar as it is a reflection of what we currently do) but ...

@BillyONeal BillyONeal added category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. labels Jun 30, 2020
BillyONeal
BillyONeal approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE HARDER!!!1!

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Jul 1, 2020
@BillyONeal
[vcpkg] Add throw after all Write-Error calls for consistency with mi…
b7007ac 
…crosoft#12172
@JackBoosY JackBoosY self-assigned this Jul 1, 2020
@strega-nil
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 0084acc into microsoft:master Jul 1, 2020
BillyONeal added a commit that referenced this pull request Jul 1, 2020
@BillyONeal
[vcpkg] VM Update (#12176)
532db1d 
* [qt5] Add more dependent Linux packages for #11596

* [vcpkg] Add LLVM 10 to Windows CI machines for #11655

* [vcpkg] Add missing Param block to InstallLLVM function.

* [vcpkg] Add throw after all Write-Error calls for consistency with #12172
@strega-nil strega-nil deleted the macos-ci-scripts branch July 2, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@ras0219 ras0219 ras0219 approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@strega-nil @ras0219 @BillyONeal @Neumann-A @JackBoosY