Update utils #2512
Merged
Update utils #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -772,13 +772,13 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@microsoft/eslint-config-azuretools": "^0.1.0", | |||
| "@microsoft/vscode-azext-dev": "^0.1.3", | |||
| "@microsoft/vscode-azext-dev": "^1.0.4", | |||
There was a problem hiding this comment.
Why not just go directly to 2.0.0 of all these packages?
nturinski
reviewed
Jun 12, 2023
src/commands/registerCommands.ts
Outdated
| registerSiteCommand('appService.Redeploy', unwrapArgs(redeployDeployment)); | ||
| registerSiteCommand('appService.viewDeploymentLogs', unwrapArgs(viewDeploymentLogs)); | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| //@ts-ignore |
There was a problem hiding this comment.
If I recall correctly, I think that what you're ignoring here is fixed by Alex's PR.
Was the ts error related to the arguments not matching the command callback or something?
There was a problem hiding this comment.
Yup Alex had recommended just ignoring the error with a ts-ignore since I guess he was working on that PR, but I can remove those once the changes are in.
Merged
alexweininger
previously approved these changes
Jun 27, 2023
|
Fixup the CI errors and then this is good to go. |
|
Maybe try updating the CI to use Node 16. |
.azure-pipelines/common/build.yml
Outdated
Comment on lines
2
to
16
| - task: NodeTool@0 | ||
| displayName: 'Use Node 14.x' | ||
| inputs: | ||
| versionSpec: 14.x | ||
| - task: NodeTool@0 | ||
| displayName: "Use Node 16.x" | ||
| inputs: | ||
| versionSpec: 16.x | ||
|
|
||
| - task: Npm@1 | ||
| displayName: 'npm ci' | ||
| inputs: | ||
| command: ci | ||
| - task: Npm@1 | ||
| displayName: "npm ci" | ||
| inputs: | ||
| command: ci | ||
|
|
||
| - task: Npm@1 | ||
| displayName: 'Build' | ||
| inputs: | ||
| command: custom | ||
| customCommand: run build |
There was a problem hiding this comment.
It's really small, but can you revert the inadvertent changes here. Mostly to preserve the git blame for this file.
alexweininger
approved these changes
Jun 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update needed in order to add support for service connector.
Includes code changes to fix errors that came with updating the package. Also had to update vscode and vscode-azext-dev versions in order to fix all issues.