Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Fix TreeNodeCommandCallback typing #1492

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

alexweininger
Copy link
Member

If a command callback has two parameters after the nodes param, with unique types. It will cause a type error since for some reason unknown is strict enough that it can't be expanded to a union of all the parameter types. It works fine with any though.

image

@alexweininger alexweininger requested a review from a team as a code owner June 9, 2023 23:26
@alexweininger alexweininger merged commit 894a251 into main Jun 12, 2023
@alexweininger alexweininger deleted the alex/copper-catfish branch June 12, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants