Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value for mingwSearchDirs #2942

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Remove default value for mingwSearchDirs #2942

merged 2 commits into from
Jan 12, 2023

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Jan 11, 2023

Remove the default path for cmake.mingwSearchDirs since the path is world-writable.

@bobbrow bobbrow merged commit 8130dfb into main Jan 12, 2023
@bobbrow bobbrow deleted the bobbrow/mingwDefault branch January 12, 2023 16:46
@bobbrow bobbrow added this to the 1.13 milestone Jan 19, 2023
@sean-mcmanus
Copy link
Contributor

@bobbrow Without the default value, the description isn't sufficient to understand the format of the setting, e.g. setting

"cmake.mingwSearchDirs": [
        "C:\\msys64\\mingw64\\bin"
    ]

doesn't work. The "\bin" has to be removed. It may be helpful to others if the description included an example or something.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants