Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs on cmake.mingwSearchDirs #2998

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Conversation

elahehrashedi
Copy link
Contributor

@elahehrashedi elahehrashedi commented Feb 3, 2023

bugfix: #2996

@elahehrashedi elahehrashedi linked an issue Feb 3, 2023 that may be closed by this pull request
@bobbrow
Copy link
Member

bobbrow commented Feb 3, 2023

I think it's better to just not add 'bin' to the path. Fix it here:

return mingwDirs.map(mingwDir => path.join(mingwDir, 'bin'));

Otherwise we also have to explain it in package.nls.json. It's easier to just not append 'bin'.

Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix it to work instead of updating the description.

@elahehrashedi
Copy link
Contributor Author

Let's fix it to work instead of updating the description.

The description needed to be updated to show that we removed the default value #2942

@elahehrashedi elahehrashedi merged commit 85cbaff into main Feb 13, 2023
@elahehrashedi elahehrashedi deleted the elrashed/updateDocs branch February 13, 2023 22:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cmake.mingwSearchDirs documentation
2 participants