Ensure default persistent values get persisted #13074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/microsoft/vscode-cpptools into coleng/dont_reset_everyones_database
This reverts commit 450d214.
This reverts commit 6979c6b.
…nto coleng/dont_reset_everyones_database
sean-mcmanus
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables dynamically passing different values for the 'default' value of a persistent state, persisting the first such default provided. Without this change, the default would not be persisted, and specifying a different default value in the future would just alter the value to match the new default (if not otherwise given a non-default value).
This is needed to fix: #13073