Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure default persistent values get persisted #13074

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Ensure default persistent values get persisted #13074

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
46c7dd5
Don't reset everyones databases
Colengms Dec 19, 2024
40aefaf
Merge branch 'main' into coleng/dont_reset_everyones_database
Colengms Dec 19, 2024
450d214
Address PR feedback
Colengms Dec 19, 2024
fc5f90c
Merge branch 'coleng/dont_reset_everyones_database' of https://github…
Colengms Dec 19, 2024
6979c6b
Revert "Address PR feedback"
Colengms Dec 19, 2024
18640e6
Reapply "Address PR feedback"
Colengms Dec 19, 2024
9b15276
Always write the default to the state store, if unset
Colengms Dec 19, 2024
0a19ef8
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
Colengms Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Extension/src/LanguageServer/persistentState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ class PersistentStateBase<T> {
this.defaultvalue = defaultValue;
this.state = state;
this.curvalue = defaultValue;

// Ensure the default is written to the state store.
if (this.state && this.state.get<T>(this.key) === undefined) {
void this.state.update(this.key, this.defaultvalue);
}
}

public get Value(): T {
Expand Down
Loading