Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dockerfile language server to 0.7.3 #3355

Merged

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Dec 12, 2021

This update to the Dockerfile language server fixes three issues that have been raised by the community:

FROM alpine as alpine
# invoke Intellisense at the end of COPY, the CPU usage of the
# Dockerfile language server should not jump to 99% (issue #3347)
COPY . . 
FROM node:alpine
# invoke Intellisense at the end of this ADD instruction,
# there should be no more errors (issue #3349)
ADD --chown=user:group
# invoke Intellisense at the end of this COPY instruction,
# there should be no more errors (issue #3349)
COPY --chown=user:group

# issue #3327
# 1. format the document, these three lines should not change
# 2. highlight and select the three lines and use format selection,
# the three lines should not change
# 3. add a backslash (\) after "cat", the EOT line should not move
RUN <<EOT
    cat
EOT

This update includes fixes for textDocument/completion requests and
updates the formatter to ignore heredocs.

Signed-off-by: Remy Suen <[email protected]>
@rcjsuen rcjsuen requested a review from a team as a code owner December 12, 2021 12:24
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Dec 13, 2021

image

I've contributed before but it looks like the build doesn't think so. Let me know if you all need me to do something different or whatever.

@bwateratmsft
Copy link
Collaborator

I've contributed before but it looks like the build doesn't think so. Let me know if you all need me to do something different or whatever.

Weird...oh well, I approved it to run. Maybe its memory only extends back to the point where we added this GitHub Action.

Copy link
Collaborator

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwateratmsft bwateratmsft merged commit 23a82c2 into microsoft:main Dec 13, 2021
@rcjsuen rcjsuen deleted the dockerfile-language-server-0.7.3 branch December 13, 2021 16:34
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Dec 13, 2021

@bwateratmsft Thanks for the review!

Is the team planning to cut a new release this month or next month?

@bwateratmsft
Copy link
Collaborator

Given the holidays and lots of people taking time off, we're planning to skip a month, so releasing tentatively 17 Jan.

@microsoft microsoft locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants