Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Dockerfile language server to 0.8.0 #3399

Merged

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Jan 23, 2022

This new release improves the semantic highlighting support for variables in addition to correcting a false positive linting error about empty continuation lines on here-documents. Please test these two new changes with the Dockerfile below.

FROM node:alpine
# the variables should now
# have symbols in a
# different color
RUN echo ${variable:+word}
RUN echo ${variable:-word}
# there should not be an
# empty continuation line
# error here
RUN <<EOT
    abc

    def
EOT

Screenshot taken with the "Tomorrow Night Blue" theme:
image

This new release improves the semantic highlighting support for
variables in addition to correcting a false positive linting error about
empty continuation lines on here-documents.

Signed-off-by: Remy Suen <[email protected]>
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Jan 23, 2022

Same as last month (#3355 (comment)), GitHub Actions doesn't want to run the build... 🤔

Copy link
Collaborator

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as always @rcjsuen, thank you!

@bwateratmsft bwateratmsft added this to the 1.20.0 milestone Jan 24, 2022
@bwateratmsft bwateratmsft merged commit 07af6e8 into microsoft:main Jan 24, 2022
@rcjsuen rcjsuen deleted the dockerfile-language-server-0.8.0 branch January 24, 2022 17:47
@microsoft microsoft locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants