This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #32
Hints can be added to
package.nls.json
in the following format:There was already support in place for objects with a
message
field inpackage.nls.json
, so this should not break compatibility with that.There was existing support in
addFile()
for acomment
array to be pass in via thekey
(though, usingmessage
would have made more sense to me). This looks to be used by existing support for hints in calls tolocalize()
. I updatedcreateXlfFiles()
to leverage this existing support to store hints/comments frompackage.nls.json
in thekey
.I also updated
addFile()
to use only thekey
string value itself for comparisons withexistingKeys
.