-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the markdownDescription property for settings #4544
Comments
This is potentially problematic, as our settings descriptions get localized. We could see problems if the localization team does not use markdown in translations, or uses characters that inadvertently trigger markdown formatting. |
I have this issue open against nls-dev, which doesn't appear to have gotten any attention. We could look at contributing this to nls-dev. microsoft/vscode-nls-dev#21 |
Although the vscode-nls-dev issue I mentioned has been closed, it did not address the lack of a way to specify a 'hint' to localizers for strings defined in |
I created a PR to enable support for this, in vscode-nls-dev: microsoft/vscode-nls-dev#33 |
We should also change all the settings reference to be like `#editor.tabSize#` so that they're linked. |
Note that this is currently blocked until the next release of VS Code (>1.57.x), due to depending on this change: microsoft/vscode#126462 |
@Colengms 1.57.0 is already released....so it's not blocked? |
1.57.0 was released on June 10. The fix was submitted on June 21. I assume that means we need to wait until 1.58 is released. |
Okay, looks like they plan to release 1.58.0 any day now (microsoft/vscode#127394) ...but I'm not sure if that's too early to have a 1.58.0 pre-requisite for 1.6.0. |
Fixed in my clang-tidy branch...I might port it team/vcls/vscode later. |
settings descriptions in
package.json
that reference enum values should use themarkdownDescription
property instead ofdescription
.The text was updated successfully, but these errors were encountered: