Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10437: Update launch.json handling to support "listen" and "connect" #10517

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

int19h
Copy link

@int19h int19h commented Mar 11, 2020

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Mar 11, 2020

Codecov Report

Merging #10517 into master will decrease coverage by 0.06%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10517      +/-   ##
==========================================
- Coverage   60.86%   60.79%   -0.07%     
==========================================
  Files         579      578       -1     
  Lines       31290    31288       -2     
  Branches     4449     4452       +3     
==========================================
- Hits        19045    19022      -23     
- Misses      11282    11299      +17     
- Partials      963      967       +4     
Impacted Files Coverage Δ
src/client/debugger/extension/adapter/factory.ts 94.28% <94.44%> (-1.43%) ⬇️
...lient/common/application/applicationEnvironment.ts 19.04% <0.00%> (-14.29%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...ient/datascience/jupyter/kernels/kernelSelector.ts 76.37% <0.00%> (-1.23%) ⬇️
...active-common/intellisense/intellisenseProvider.ts 37.09% <0.00%> (-0.74%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 5.53% <0.00%> (-0.18%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2603a...557e3a0. Read the comment docs.

@int19h int19h requested a review from karthiknadig March 11, 2020 19:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@int19h int19h merged commit 0aa6088 into microsoft:master Mar 12, 2020
@int19h int19h deleted the 10437 branch March 12, 2020 18:04
DonJayamanne added a commit that referenced this pull request Mar 13, 2020
* master:
  Fix flakey file system tests (#10541)
  Tweaks for gather (#10532)
  Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517)
  Add conda support to nightly flake test (#10523)
  Rename datascience to datascience_modules (#10525)
  Clean up the extension activation code. (#10455)
  Allow escape and ctrl+U to clear the interactive window (#10513)
  Fix builtins so they don't interfere with our execution (#10511)
  Jupyter autocompletion will only show up on empty lines, (#10420)
  notify on missing kernel and interpreter with kernel (#10508)
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Mar 18, 2020
karthiknadig added a commit that referenced this pull request Mar 19, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants