Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for gather #10532

Merged
merged 7 commits into from
Mar 12, 2020
Merged

Tweaks for gather #10532

merged 7 commits into from
Mar 12, 2020

Conversation

greazer
Copy link
Member

@greazer greazer commented Mar 12, 2020

No description provided.

@greazer greazer added the no-changelog No news entry required label Mar 12, 2020
@codecov-io
Copy link

codecov-io commented Mar 12, 2020

Codecov Report

Merging #10532 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10532      +/-   ##
==========================================
- Coverage   60.76%   60.74%   -0.03%     
==========================================
  Files         578      578              
  Lines       31355    31355              
  Branches     4463     4464       +1     
==========================================
- Hits        19053    19046       -7     
- Misses      11335    11339       +4     
- Partials      967      970       +3     
Impacted Files Coverage Δ
src/client/datascience/gather/gather.ts 32.81% <ø> (ø)
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/debugger/extension/adapter/factory.ts 94.28% <0.00%> (-1.43%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b04ed7...68c3c37. Read the comment docs.

@greazer greazer requested a review from DonJayamanne March 12, 2020 07:39
package.json Show resolved Hide resolved
rchiodo
rchiodo previously approved these changes Mar 12, 2020
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@greazer greazer requested review from rchiodo and DonJayamanne March 12, 2020 20:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo rchiodo dismissed their stale review March 12, 2020 20:57

revoking review

Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@greazer greazer merged commit d57ce9f into master Mar 12, 2020
@greazer greazer deleted the dev/jim/update-build-for-gather branch March 12, 2020 22:38
DonJayamanne added a commit that referenced this pull request Mar 13, 2020
* master:
  Fix flakey file system tests (#10541)
  Tweaks for gather (#10532)
  Fix #10437: Update launch.json handling to support "listen" and "connect" (#10517)
  Add conda support to nightly flake test (#10523)
  Rename datascience to datascience_modules (#10525)
  Clean up the extension activation code. (#10455)
  Allow escape and ctrl+U to clear the interactive window (#10513)
  Fix builtins so they don't interfere with our execution (#10511)
  Jupyter autocompletion will only show up on empty lines, (#10420)
  notify on missing kernel and interpreter with kernel (#10508)
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants