Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extensionUrl instead of extensionPath #19122

Merged
merged 1 commit into from
May 11, 2022

Conversation

karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added no-changelog No news entry required skip tests Updates to tests unnecessary labels May 11, 2022
@karthiknadig karthiknadig requested a review from kimadeline May 11, 2022 00:14
@karthiknadig karthiknadig self-assigned this May 11, 2022
@karthiknadig karthiknadig changed the title Use extensionUrl instead of extensionPath (#19120) Use extensionUrl instead of extensionPath May 11, 2022
@karthiknadig karthiknadig merged commit fee6a2f into microsoft:main May 11, 2022
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request May 17, 2022
karrtikr pushed a commit that referenced this pull request May 18, 2022
…a different interpreter, or when a particular scope is opened for the first time (#19162)

* Add progress API

* Remove old API in favor of this

* Revert "Remove old API in favor of this"

This reverts commit 9543501.

* Revert "Revert "Remove old API in favor of this""

This reverts commit 5bbea78.

* Fix

* Remove old API impl

* Add to proposed API

* Add get refresh promise options

* Change getter to function

* Translate progress events to progress promises

* Fix combining iterators

* Fix tests

* Add test for resolver

* Add test for reducer

* Fixes

* Add tests for environment collection service

* News entry

* Add another test if a query is provided

* Add comments and clarify

* Fix bug

* Use extensionUrl instead of extensionPath (#19122)

* Only trigger auto environment discovery once in the first session for a particular scope

* Oops

* Ensure old Jupyter APIs still have the old behavior

* Trigger auto-discovery if a user is attempting to choose a different interpreter

* Fix tests

* Temp

* Add an option to trigger refresh for the session

* Fix bugs

* Fix tests

* Remove trigger from telemetry

* Add tests for options

Co-authored-by: Karthik Nadig <[email protected]>
@karthiknadig karthiknadig deleted the cherry1 branch June 8, 2022 20:23
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…a different interpreter, or when a particular scope is opened for the first time (microsoft/vscode-python#19162)

* Add progress API

* Remove old API in favor of this

* Revert "Remove old API in favor of this"

This reverts commit 9543501576cd063e6aad1ef3ddd7a39cb3354b22.

* Revert "Revert "Remove old API in favor of this""

This reverts commit 5bbea78879f2447c6783d7ad98610d4af36abf29.

* Fix

* Remove old API impl

* Add to proposed API

* Add get refresh promise options

* Change getter to function

* Translate progress events to progress promises

* Fix combining iterators

* Fix tests

* Add test for resolver

* Add test for reducer

* Fixes

* Add tests for environment collection service

* News entry

* Add another test if a query is provided

* Add comments and clarify

* Fix bug

* Use extensionUrl instead of extensionPath (microsoft/vscode-python#19122)

* Only trigger auto environment discovery once in the first session for a particular scope

* Oops

* Ensure old Jupyter APIs still have the old behavior

* Trigger auto-discovery if a user is attempting to choose a different interpreter

* Fix tests

* Temp

* Add an option to trigger refresh for the session

* Fix bugs

* Fix tests

* Remove trigger from telemetry

* Add tests for options

Co-authored-by: Karthik Nadig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant