Only trigger auto environment discovery if a user attempts to choose a different interpreter, or when a particular scope is opened for the first time #19162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
May 10, 2022 23:20
karrtikr
changed the title
… a particular scope
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…a different interpreter, or when a particular scope is opened for the first time (microsoft/vscode-python#19162) * Add progress API * Remove old API in favor of this * Revert "Remove old API in favor of this" This reverts commit 9543501576cd063e6aad1ef3ddd7a39cb3354b22. * Revert "Revert "Remove old API in favor of this"" This reverts commit 5bbea78879f2447c6783d7ad98610d4af36abf29. * Fix * Remove old API impl * Add to proposed API * Add get refresh promise options * Change getter to function * Translate progress events to progress promises * Fix combining iterators * Fix tests * Add test for resolver * Add test for reducer * Fixes * Add tests for environment collection service * News entry * Add another test if a query is provided * Add comments and clarify * Fix bug * Use extensionUrl instead of extensionPath (microsoft/vscode-python#19122) * Only trigger auto environment discovery once in the first session for a particular scope * Oops * Ensure old Jupyter APIs still have the old behavior * Trigger auto-discovery if a user is attempting to choose a different interpreter * Fix tests * Temp * Add an option to trigger refresh for the session * Fix bugs * Fix tests * Remove trigger from telemetry * Add tests for options Co-authored-by: Karthik Nadig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19102
Things considered: