Finalise notebook API for notebook document change events

[jrieken]

LSP adds support for notebooks but currently depends on some proposed API, mostly events for saving and observe changes to the document. We should investigate what it takes to finalise those

• support notebookType in document selectors
• notebook document events -> src/vscode-dts/vscode.proposed.notebookDocumentEvents.d.ts

[jrieken]

fyi @dbaeumer @rebornix

[jrieken]

fyi @karthiknadig The simplified events are defined in https://github.com/microsoft/vscode/blob/d4c26aa154f2506614f5a292bc598c7ce07dbf36/src/vscode-dts/vscode.proposed.notebookDocumentEvents.d.ts. They will replace the following events defined in vscode.notebook (from the notebookEditor-proposal):

• vscode.notebook.onDidChangeCellMetadata -> replaced with vscode.workspace.onDidChangeNotebookDocument
• onDidChangeCellOutputs -> replaced with vscode.workspace.onDidChangeNotebookDocument
• onDidChangeNotebookCells -> replaced with vscode.workspace.onDidChangeNotebookDocument
• onDidChangeNotebookDocumentMetadata -> replaced with vscode.workspace.onDidChangeNotebookDocument
• vscode.notebook.onDidSaveNotebookDocument -> moved into vscode.workspace, no other changes

I have enroled ms-toolsai.jupyter into the notebookDocumentEvents proposal meaning the extension can migrate safely.

[dbaeumer]

Did the same for Pylance and eslint so we can move off when I have released a new version of the LSP libs

[jrieken]

Moving to April for

• removal of the old events
• finalisation attempt of the new events

[jrieken]

Moving to April for

• removal of the old events
• finalisation attempt of the new events

[DonJayamanne]

I have enroled ms-toolsai.jupyter into the notebookDocumentEvents proposal meaning the extension can migrate safely.

Done

[dbaeumer]

Thanks!!

[jrieken]

To verify:

make sure latest vscode.d.ts has vscode.workspace.onDidChangeNotebookDocument and vscode.workspace.onDidSaveNotebookDocument