Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new notebook document change events #145555

Closed
2 tasks done
jrieken opened this issue Mar 21, 2022 · 2 comments
Closed
2 tasks done

Test new notebook document change events #145555

jrieken opened this issue Mar 21, 2022 · 2 comments

Comments

@jrieken
Copy link
Member

jrieken commented Mar 21, 2022

Refs: #144662

Complexity: 3

Create Issue


There is a new API proposal which is about a notebook change event. The TPI is about testing this new proposal

	"enabledApiProposals": [
		"notebookDocumentEvents"
	],

Test that

  • there is doc and it makes sense
  • the vscode.workspace.onDidSaveNotebookDocument-event fires whenever a notebook is saved
  • the vscode.workspace.onDidChangeNotebookDocument-event fires whenever a notebook changes: this includes structural changes, like add, remove, or replace cells, as well as output and metadata changes.
@jrieken jrieken added this to the March 2022 milestone Mar 21, 2022
@ghost ghost assigned kimadeline and joaomoreno Mar 22, 2022
@joaomoreno
Copy link
Member

Now that's how you create a proper test item setup section! 👏

joaomoreno added a commit that referenced this issue Mar 22, 2022
related to #145555
@joaomoreno
Copy link
Member

Just found minor language doc fixes, which I found easier for me to just fix as opposed to giving you an issue for them: 22319a1

@rchiodo rchiodo removed their assignment Mar 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants