Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview custom context menus don't work after reload #156491

Closed
mjbvz opened this issue Jul 27, 2022 · 0 comments · Fixed by #156492
Closed

Webview custom context menus don't work after reload #156491

mjbvz opened this issue Jul 27, 2022 · 0 comments · Fixed by #156492
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2022

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 27, 2022

Testing #156224

  1. Using the code in the Test webview context menus proposal  #156224
  2. Open the cat coding webview
  3. Reload the window
  4. Now in the restored webview, right click to try showing a custom context menu

bug
default context menus show instead
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jul 27, 2022
@mjbvz mjbvz added this to the July 2022 milestone Jul 27, 2022
@mjbvz mjbvz self-assigned this Jul 27, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 27, 2022
@mjbvz
Fix webview providerId not being restored on reload
9f3770e 
Fixes microsoft#156491
@mjbvz mjbvz mentioned this issue Jul 27, 2022
Merged
mjbvz added a commit that referenced this issue Jul 27, 2022
@mjbvz
Fix webview providerId not being restored on reload (#156492)
4aa9759 
Fixes #156491
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 27, 2022
@connor4312 connor4312 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Fix webview providerId not being restored on reload mjbvz/vscode
3 participants
@connor4312 @mjbvz @vscodenpa