Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webview providerId not being restored on reload #156492

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jul 27, 2022

Fixes #156491

@mjbvz mjbvz added this to the July 2022 milestone Jul 27, 2022
@mjbvz mjbvz self-assigned this Jul 27, 2022
@mjbvz mjbvz enabled auto-merge (squash) July 27, 2022 18:50
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These additions seem like a good use case for Untyped Editor inputs. These untyped editor inputs can also be thought of as editor input DTOs which are used for the resolver service to contain the minimum set of information needed to resolve an editor. Not sure if we can use that here, it's also very similar to what we have as the editor representation in the tabs api. The untyped inputs can be found here

export type IUntypedEditorInput = IResourceEditorInput | ITextResourceEditorInput | IUntitledTextResourceEditorInput | IResourceDiffEditorInput | IResourceSideBySideEditorInput | IResourceMergeEditorInput;
(will probably soon be renamed to unresolved)

@mjbvz mjbvz merged commit 4aa9759 into microsoft:main Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webview custom context menus don't work after reload
2 participants