Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Underline is not continuous #158868

Closed
aeschli opened this issue Aug 23, 2022 · 3 comments · Fixed by #159494
Closed

Terminal: Underline is not continuous #158868

aeschli opened this issue Aug 23, 2022 · 3 comments · Fixed by #159494
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
September 2022

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 23, 2022 •
edited
Loading

Testing #158827

Version: 1.71.0-insider
Commit: bd61073
Date: 2022-08-23T05:19:02.563Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: Yes

  • set setting terminal.integrated.gpuAcceleration: on
  • in a terminal type: echo -e "\x1b[4:2m" # double underline followed by echo -e "\x1b[4:3m" # curly underline and a new line

image

Especially under the w there's a lot of space so I would say it can't be antialiasing that interferes
@aeschli aeschli changed the title Underline is not continuous Terminal: Underline is not continuous Aug 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

Good find, the stroke seems oddly large on the w here.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal-rendering labels Aug 23, 2022
@Tyriar Tyriar added this to the Backlog milestone Aug 23, 2022
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Aug 23, 2022
@Tyriar Tyriar mentioned this issue Aug 23, 2022
Closed
@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

Upstream: xtermjs/xterm.js#4059

@Tyriar Tyriar added the upstream-issue-linked This is an upstream issue that has been reported upstream label Aug 23, 2022
@Tyriar Tyriar modified the milestones: Backlog, September 2022 Aug 29, 2022
@Tyriar Tyriar added the upstream-issue-fixed The underlying upstream issue has been fixed label Aug 29, 2022
Tyriar added a commit that referenced this issue Aug 29, 2022
@Tyriar
Update xterm.js
b02e85c 
Fixes #159492
Fixes #159493
Fixes #158868
Fixes #158981
Fixes #157432
@Tyriar Tyriar mentioned this issue Aug 29, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2022
@aeschli
Copy link
Contributor Author

aeschli commented Sep 28, 2022

Looks better on the Mac now.
image

@aeschli aeschli added the verified Verification succeeded label Sep 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Update xterm.js
77eeef2 
Fixes microsoft#159492
Fixes microsoft#159493
Fixes microsoft#158868
Fixes microsoft#158981
Fixes microsoft#157432
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

Update xterm.js microsoft/vscode
4 participants
@Tyriar @aeschli @meganrogge @vscodenpa