Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline is not continuous #4059

Closed
Tyriar opened this issue Aug 23, 2022 · 3 comments · Fixed by #4074
Closed

Underline is not continuous #4059

Tyriar opened this issue Aug 23, 2022 · 3 comments · Fixed by #4074
Assignees
Labels
area/addon/webgl type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 23, 2022

VS Code issue: microsoft/vscode#158868

  • set setting terminal.integrated.gpuAcceleration: on
  • in a terminal type: echo -e "\x1b[4:2m" # double underline followed by echo -e "\x1b[4:3m" # curly underline and a new line

image

Especially under the w there's a lot of space so I would say it can't be antialiasing that interferes


I wonder if we should reduce the stroke width here, or potentially do something more manual when drawing the lines to ensure only characters that need it get this treatment?

@TylerLeonhardt-alt
Copy link

TylerLeonhardt-alt commented Aug 23, 2022

v has the same issue as w

This is @TylerLeonhardt's alt

@TylerLeonhardt-alt
Copy link

image

Wanted to call out the others. Some make sense like @, $, {}, |, ;. The suspicious ones, I think, are: (), _, [], / and \.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 23, 2022

I'm thinking of only doing the outline handling if the glyph has any pixels set on the underline's top row of pixels (or below), I think that should fix those cases

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 26, 2022
@Tyriar Tyriar self-assigned this Aug 26, 2022
@Tyriar Tyriar added this to the 5.0.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants