Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more accessibility.verbosity settings / hints #180470

Closed
meganrogge opened this issue Apr 21, 2023 · 8 comments
Closed

add more accessibility.verbosity settings / hints #180470

meganrogge opened this issue Apr 21, 2023 · 8 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@meganrogge
Copy link
Contributor

          With the initial small set that we allow configuring in #180365, we should find other components that would benefit from:
  1. a setting like this
  2. an aria-label with helpful information and then a setting like this

Originally posted by @meganrogge in #172465 (comment)

@meganrogge meganrogge self-assigned this Apr 21, 2023
@meganrogge meganrogge changed the title With the initial small set that we allow configuring in #180365, we should find other components that would benefit from: add more accessibility.verbosity settings / hints Apr 21, 2023
@meganrogge meganrogge added this to the May 2023 milestone Apr 21, 2023
@meganrogge meganrogge added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Apr 21, 2023
@amunger
Copy link
Contributor

amunger commented May 4, 2023

I noticed that the notebook editor has an aria alert when certain parts of a cell are focused with some navigation hints. I haven't actually seen it triggered much when playing around with it, but it seems potentially noisy and could benefit from this setting - https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts#L2239

@mjbvz
Copy link
Collaborator

mjbvz commented May 4, 2023

Should also potentially be added to the public api on the AccessibilityInformation type

meganrogge added a commit that referenced this issue May 20, 2023
@microsoft microsoft deleted a comment from vscodenpa May 23, 2023
@meganrogge
Copy link
Contributor Author

I'll continue to think about this, but considering this finished for now

@meganrogge
Copy link
Contributor Author

Verify that the accessibility verbosity setting description makes sense and that it works when you have a screen reader on for accessibility.verbosity.notebook and accessibility.verbosity.keybindingsEditor

for notebooks, you should see press escape to focus the cell container... or press enter to focus the inner... depending on where you click.

for the keybindings editor, when you focus a row, you should see use space or enter to change the keybinding

@meganrogge meganrogge added the verification-needed Verification of issue is requested label May 30, 2023
@meganrogge
Copy link
Contributor Author

@rebornix can you pls provide more specific steps for the notebook case as I found it hard to trigger as did @amunger ?

@joyceerhl joyceerhl added the verified Verification succeeded label May 31, 2023
@joyceerhl
Copy link
Collaborator

If I have a markdown cell in preview mode and hit enter, I hear 'press escape to focus the cell container'. If I then press escape to put the cell back into preview mode, I then hear 'press enter to focus the inner markdown editor. These instructions are not announced if I have accessibility.verbosity.notebook` disabled ✅.

When I click into a notebook cell editor I hear 'the editor is not accessible at this time', which I don't really understand, is that expected?

@meganrogge
Copy link
Contributor Author

When I click into a notebook cell editor I hear 'the editor is not accessible at this time', which I don't really understand, is that expected?

That sounds like a bug, but unrelated to these changes. @rebornix might have more info

@joyceerhl
Copy link
Collaborator

I'll file an issue

@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants