add notebook verbosity setting #183038
Merged
add notebook verbosity setting #183038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
May 26, 2023
| if (index !== undefined && index >= 0) { | ||
| let position = ''; | ||
| switch (focusItem) { | ||
| case 'editor': | ||
| position = `the inner ${cell.cellKind === CellKind.Markup ? 'markdown' : 'code'} editor is focused, press escape to focus the cell container`; | ||
| position = `the inner ${cell.cellKind === CellKind.Markup ? 'markdown' : 'code'} editor is focused` + verboseLabel ? `, press escape to focus the cell container` : ''; |
There was a problem hiding this comment.
Suggested change
| position = `the inner ${cell.cellKind === CellKind.Markup ? 'markdown' : 'code'} editor is focused` + verboseLabel ? `, press escape to focus the cell container` : ''; | |
| position = `the inner ${cell.cellKind === CellKind.Markup ? 'markdown' : 'code'} editor is focused` + (verboseLabel ? `, press escape to focus the cell container` : ''); |
rebornix
reviewed
May 26, 2023
src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
Outdated
Show resolved
Hide resolved
rebornix
reviewed
May 26, 2023
src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
Outdated
Show resolved
Hide resolved
rebornix
reviewed
May 26, 2023
bhavyaus
approved these changes
May 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #180470
@amunger I couldn't figure out how to trigger the original aria message, could you pls test this?