Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to skip the prompt to save the workspace config #187794

Closed
spersico opened this issue Jul 13, 2023 · 7 comments · Fixed by #200114
Closed

Add the option to skip the prompt to save the workspace config #187794

spersico opened this issue Jul 13, 2023 · 7 comments · Fixed by #200114
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues

Comments

@spersico
Copy link

spersico commented Jul 13, 2023

When opening multiple folders at once, and then either closing the window or selecting other folders, a prompt appears, asking the user (with the message “Do you want to save your workspace configuration as a file?”) if it wants to Save/Not Save, or Cancel the action.

image

I propose that the prompt should be globaly skippable via a configuration option.


This is reproducible without extensions, and in every OS, as far as I know. It's not a bug.
Here's the code that shows the prompt

To reproduce:

  1. Open multiple folders with a command such as code -n --disable-extensions DirectoryA DirectoryB,
  2. attempt to close the window, or select some other folder, via the menu File > Open > Open folder > (Select some Directory)
image
  1. After selecting a folder, or another group of folders, and clicking Open

I opened this issue because there are multiple issues (#42657, #30974, #30972) that I believe were closed between 2017 and 2019, and some comment reactions seem to agree with me that this is a desirable feature. There was even a person who expressed interest in making a PR to implement the feature.

My use case is pretty simple, and in my opinion, not weird:
I work with multiple frontends and one backend, and for performance and clarity reasons, I prefer to open the least amount of frontend-backend folders I need for the task at hand. Every time I switch I see the prompt, that annoys me because I don't intend to save a workspace for every combination.

@bpasero bpasero added feature-request Request for new features or functionality workbench-multiroot Multi-root (multiple folders) issues labels Jul 21, 2023
@bpasero bpasero removed their assignment Jul 21, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Jul 21, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa modified the milestones: Backlog Candidates, Backlog Sep 12, 2023
@SebDominguez
Copy link

I'm surprised to see that this is still not yet implemented.

@bpasero
Copy link
Member

bpasero commented Dec 6, 2023

Adding a checkbox to the dialog:

image

Enabling that would update a new setting window.confirmSaveUntitledWorkspace to false. From then on, the dialog no longer asks to save and untitled workspaces are discarded.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 6, 2023
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Dec 8, 2023
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@spersico, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 02b9071 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@spersico
Copy link
Author

spersico commented Dec 8, 2023

/verified
Tested with today's version of VS Code Insiders, both switching the folders, and closing the editor. I don't see the prompt anymore.
Thanks a lot @bpasero! 🥇

@vscodenpa vscodenpa added verified Verification succeeded and removed author-verification-requested Issues potentially verifiable by issue author labels Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants