Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very brief flicker when opening inline chat again #218059

Closed
jrieken opened this issue Jun 25, 2024 · 0 comments · Fixed by #218318
Closed

Very brief flicker when opening inline chat again #218059

jrieken opened this issue Jun 25, 2024 · 0 comments · Fixed by #218318
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2024

Comments

@jrieken
Copy link
Member

jrieken commented Jun 25, 2024

  • use "inlineChat.experimental.textButtons": true
  • open inline chat
  • type a query so that the blue button shows
  • select ESC to close and then trigger inline chat again
  • 🐛 short blue button flicker
Screen.Recording.2024-06-25.at.15.52.49.mov
@jrieken jrieken self-assigned this Jun 25, 2024
@jrieken jrieken added this to the June 2024 milestone Jun 25, 2024
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug inline-chat labels Jun 25, 2024
jrieken added a commit that referenced this issue Jun 26, 2024
@jrieken
fix #218059
b550e24
@jrieken jrieken mentioned this issue Jun 26, 2024
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 26, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2024
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jun 26, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@jrieken @aaronchucarroll
Inline chat fixes (microsoft#218318)
e2e87e8 
* fix microsoft#218059

* Change enablement of "Toggle Changes" instead of visibility

mitigates/fixes microsoft#218099

* have padding per part (actions, input, list)

fixes microsoft#218083

* fixes microsoft#218021

* fix notebook button groups for inline chat

* tweak inline chat content widget when text btn are enabled
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug inline-chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Inline chat fixes microsoft/vscode
3 participants
@jrieken @TylerLeonhardt @vscodenpa