Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: Single item in an overflow menu is a bit strange #218099

Closed
sbatten opened this issue Jun 25, 2024 · 3 comments · Fixed by #218318
Closed

nit: Single item in an overflow menu is a bit strange #218099

sbatten opened this issue Jun 25, 2024 · 3 comments · Fixed by #218318
Assignees
@jrieken @daviddossett
Labels
inline-chat insiders-released Patch has been released in VS Code Insiders
Milestone
June 2024

Comments

@sbatten
Copy link
Member

sbatten commented Jun 25, 2024

Testing #217202

image
@daviddossett
Copy link
Contributor

I have

Image

@jrieken
Copy link
Member

jrieken commented Jun 26, 2024

It depends on the type of reply. When it's text only the "view in chat" actions moves into the primary group.

@jrieken
Copy link
Member

jrieken commented Jun 26, 2024

I could always have "Toggle Changes" and mange its enablement (instead of visibility)

@jrieken jrieken added this to the June 2024 milestone Jun 26, 2024
jrieken added a commit that referenced this issue Jun 26, 2024
@jrieken
Change enablement of "Toggle Changes" instead of visibility
d3fac76 
mitigates/fixes #218099
@jrieken jrieken mentioned this issue Jun 26, 2024
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 26, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@jrieken @aaronchucarroll
Inline chat fixes (microsoft#218318)
e2e87e8 
* fix microsoft#218059

* Change enablement of "Toggle Changes" instead of visibility

mitigates/fixes microsoft#218099

* have padding per part (actions, input, list)

fixes microsoft#218083

* fixes microsoft#218021

* fix notebook button groups for inline chat

* tweak inline chat content widget when text btn are enabled
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@daviddossett daviddossett

Labels
inline-chat insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Inline chat fixes microsoft/vscode
4 participants
@jrieken @sbatten @daviddossett @vscodenpa