Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi root support: warn developer when asking for a setting for a resource but the setting is not resource scoped #36623

Closed
egamma opened this issue Oct 20, 2017 · 0 comments
Assignees
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@egamma
Copy link
Member

egamma commented Oct 20, 2017

When in Dev mode

  • Accessing a resource configuration with out providing a resource will log following warning
[ms-vscode.configuration-sample] Accessing a resource scoped configuration without providing a resource is not expected. 
To get the effective value for 'conf.resource.insertEmptyLastLine', provide the resource for which the value is needed. 
If you would like to look up all values, use 'inspect' method instead.
  • Accessing a window configuration for a resource will log following warning
[ms-vscode.configuration-sample] Accessing a window scoped configuration for a resource is not expected. 
To associate 'conf.view.showOnWindowOpen' to a resource, define its scope to 'resource' in configuration contributions in 'package.json'. 

Following message is shown when a window setting is configured in Folder settings

image

@egamma egamma added the workbench-multiroot Multi-root (multiple folders) issues label Oct 20, 2017
@egamma egamma added this to the October 2017 milestone Oct 20, 2017
@sandy081 sandy081 added the feature-request Request for new features or functionality label Oct 20, 2017
sandy081 added a commit that referenced this issue Oct 27, 2017
@sandy081 sandy081 added config VS Code configuration, set up issues workbench labels Oct 27, 2017
sandy081 added a commit that referenced this issue Oct 27, 2017
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Oct 30, 2017
egamma pushed a commit that referenced this issue Oct 31, 2017
egamma pushed a commit that referenced this issue Oct 31, 2017
@roblourens roblourens added the verified Verification succeeded label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config VS Code configuration, set up issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants