You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #36623 - I warn those accessing configuration API to get a value for resource configuration without passing a resource or to get a value for window configuration by passing resource.
Error prone:
If you are accessing the value for resource configuration of a resource, you should be passing the resource.
Good practice:
If you are accessing the value for resource configuration of any resource, pass null
If you are accessing the value for window configuration, do not pass resource.
If you want to access different values, use inspect.
Main intention behind this is to give run-time warnings and help extension authors when they are accessing the API wrongly by mistake.
After enabling this, I see following warnings from our in built extensions those accessing resource configurations without passing a resource.
vscode.git is accessing files.encoding configuration
vscode.typescript is accessing typescript and javascript configurations
vscode.json is accessing json.scripts configuration
Owners of above extensions, go through the usages of configuration access API or go through the warnings generated in VS Code run from OOS and fix/adopt to above practises.
The text was updated successfully, but these errors were encountered:
In #36623 - I warn those accessing configuration API to get a value for resource configuration without passing a resource or to get a value for window configuration by passing resource.
Error prone:
Good practice:
null
inspect
.Main intention behind this is to give run-time warnings and help extension authors when they are accessing the API wrongly by mistake.
After enabling this, I see following warnings from our in built extensions those accessing resource configurations without passing a resource.
vscode.git
is accessingfiles.encoding
configurationvscode.typescript
is accessingtypescript
andjavascript
configurationsvscode.json
is accessingjson.scripts
configurationOwners of above extensions, go through the usages of configuration access API or go through the warnings generated in VS Code run from OOS and fix/adopt to above practises.
The text was updated successfully, but these errors were encountered: