Fixes #11451 - Add konsole as default terminal for KDE-plasma
#11452
Conversation
|
Hi @nholthaus, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -11,6 +11,8 @@ if (env.isLinux) { | |||
| defaultTerminalLinux = 'x-terminal-emulator'; | |||
| } else if (process.env.DESKTOP_SESSION === 'gnome' || process.env.DESKTOP_SESSION === 'gnome-classic') { | |||
| defaultTerminalLinux = 'gnome-terminal'; | |||
| } else if (process.env.DESKTOP_SESSION === 'kde-plasma') { | |||
There was a problem hiding this comment.
Is plasma a version or something? If so can this be made more generic?
There was a problem hiding this comment.
plasma is the name of KDE's desktop manager, not a specific version.
There was a problem hiding this comment.
So this if should be entered regardless of the specific distribution, as long as it's using KDE and not on Debian (due to the first case)? This comment I found concerns me a little, is there a more reliable environment variable if this can be the "default" on KDE Fedora?
There was a problem hiding this comment.
@Tyriar hmm, yeah I was only really thinking about improving Kubuntu. This whole section may need work if it's going to include desktop-manager specific code, even just to handle the major flavors.
That said, if old versions of KDE Fedora (or others) fall through the if, they're no worse off then they are now.
Another approach might be to have the workspace/user setting for the external terminal affect the debugger. When I tried setting it to konsole, there was no change in the "install gnome terminal" error message. Not sure if that's an issue in and of itself (or a feature) or what the side effects would be.
|
v1.5 has been branched so I think I'll merge this, the comments are trying to solve an extra problem on top of this. Note that I'm not sure that the debugger will recognize this, but will definitely launch konsole when the "Open New Terminal" command is run. The debugger issue was moved to #11451 (comment) |
No description provided.