Fixes #11451 - Add konsole as default terminal for KDE-plasma
#11452
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,8 @@ if (env.isLinux) { | |
| defaultTerminalLinux = 'x-terminal-emulator'; | ||
| } else if (process.env.DESKTOP_SESSION === 'gnome' || process.env.DESKTOP_SESSION === 'gnome-classic') { | ||
| defaultTerminalLinux = 'gnome-terminal'; | ||
| } else if (process.env.DESKTOP_SESSION === 'kde-plasma') { | ||
| defaultTerminalLinux = 'konsole'; | ||
|
There was a problem hiding this comment. Is there some environment variable that houses this? There was a problem hiding this comment. @Tyriar I'm not a KDE expert, but none was present on my (fresh install) system. |
||
| } else if (process.env.COLORTERM) { | ||
| defaultTerminalLinux = process.env.COLORTERM; | ||
| } else if (process.env.TERM) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is plasma a version or something? If so can this be made more generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plasma is the name of KDE's desktop manager, not a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this
ifshould be entered regardless of the specific distribution, as long as it's using KDE and not on Debian (due to the first case)? This comment I found concerns me a little, is there a more reliable environment variable if this can be the"default"on KDE Fedora?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tyriar hmm, yeah I was only really thinking about improving Kubuntu. This whole section may need work if it's going to include desktop-manager specific code, even just to handle the major flavors.
That said, if old versions of KDE Fedora (or others) fall through the
if, they're no worse off then they are now.Another approach might be to have the workspace/user setting for the external terminal affect the debugger. When I tried setting it to
konsole, there was no change in the "install gnome terminal" error message. Not sure if that's an issue in and of itself (or a feature) or what the side effects would be.