Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support changes in vscode-nls-dev that allow hint comments in package.nls.json #126462

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Support changes in vscode-nls-dev that allow hint comments in package.nls.json #126462

merged 1 commit into from
Jun 21, 2021

Conversation

dbaeumer
Copy link
Member

Fixes #126408

@dbaeumer
Copy link
Member Author

@joaomoreno can you please have a quick look because of the changes in extensions.ts

@dbaeumer dbaeumer assigned dbaeumer and unassigned joaomoreno Jun 16, 2021
@dbaeumer dbaeumer requested a review from joaomoreno June 16, 2021 09:55
@dbaeumer dbaeumer merged commit 04c80c9 into main Jun 21, 2021
@dbaeumer dbaeumer deleted the dbaeumer/126408 branch June 21, 2021 08:49
@Colengms Colengms mentioned this pull request Jul 7, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@dbaeumer dbaeumer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support changes in vscode-nls-dev that allow hint comments in package.nls.json
2 participants
@dbaeumer @joaomoreno