Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make files.exclude & files.watcherExclude overridable. #66451

Closed
wants to merge 1 commit into from
Closed

Make files.exclude & files.watcherExclude overridable. #66451

wants to merge 1 commit into from

Conversation

yaohaizh
Copy link

Signed-off-by: Yaohai Zheng [email protected]

Fix for #46851.

Language server extension need exclude some intermediate files.

@sandy081
Copy link
Member

@yaohaizh I do not think this overridable meant what is described in the issue. This will allow users to override settings per language. Also just marking this as overridable does not help. It should be also adopted at the places where it is being used.

Would like to understand the purpose of this fix and what it is fixing.

@yaohaizh
Copy link
Author

yaohaizh commented Jan 21, 2019

Waht we want to do is that make the following setting possible by default in the VSCode Java extension:

    "[java]": {
        "files.exclude": {
            "**/.project": true,
            "**/.classpath": true,
            "**/.settings": true
        }
    }

Without this overridable property, this is not possible in our extension package.json.

Not sure if there is another way to do it. Thanks

@sandy081
Copy link
Member

I see. @bpasero FYI

@sandy081 sandy081 assigned bpasero and unassigned sandy081 Jan 22, 2019
@bpasero
Copy link
Member

bpasero commented Jan 23, 2019

@yaohaizh we do not support these settings for specific languages. They are global for the workspace and not specific to a certain language. I am closing this PR.

@Hezkore
Copy link

Hezkore commented Jun 17, 2019

Aww this is a real shame.
I really wanted to hide some stuff that my language compiler spits out.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants