Hide java project setting files by default. #776

yaohaizh · 2019-01-25T04:51:29Z

@fbricon
Fix issue #618 which gives us lots of negative feedback and requested by the users.

Since this PR microsoft/vscode#66451 is closed by VSCode side, provide the vscode java setting to mitigate this issue.

Signed-off-by: Yaohai Zheng <[email protected]>

fbricon

maybe we should display a warning on the 1st startup of the extension, asking the user to enable that feature
if the feature is disabled globally, then you manually enable it, the files are not excluded until the next vscode restart.

fbricon · 2019-01-25T23:46:16Z

package.json

+        "java.configuration.excludeProjectSettingFiles": {
+          "type": "boolean",
+          "default": true,
+          "description": "Exclude the extension generated project setting files from file explorer.",


settings from the file explorer

need to explain setting it to false won't remove the exclusions

fbricon · 2019-01-25T23:47:50Z

src/setting.ts

+import { getJavaConfiguration } from './utils';
+
+
+const DEFAULT_HIIDEN_FILES: string[] = ['**/.classpath', '**/.project', '**/.settings'];


fbricon · 2019-01-25T23:49:26Z

package.json

@@ -89,6 +89,12 @@
          "description": "Specifies the severity of the message when the classpath is incomplete for a Java file",
          "scope": "window"
        },
+        "java.configuration.excludeProjectSettingFiles": {


hideProjectSettingsFiles

fbricon · 2019-01-25T23:50:17Z

src/setting.ts

+	});
+}
+
+export function excludeProjectSettingFiles(workspaceUri: Uri) {


excludeProjectSettingsFiles

fbricon · 2019-01-26T00:19:23Z

	"files.exclude": {
        "**/.git": true,
        "**/.svn": true,
        "**/.hg": true,
        "**/CVS": true,
        "**/.DS_Store": true,
        "**/.classpath": true,
        "**/.project": true,
        "**/.settings": true
    }

is added to the local settings.json, even if the java exclusions are already defined at the user settings level. That's a big no no

yaohaizh · 2019-01-30T05:07:19Z

@fbricon Addressed the review feedback.

Signed-off-by: Yaohai Zheng <[email protected]>

fbricon

s/setting/settings/g

fbricon · 2019-01-30T05:39:30Z

src/setting.ts

@@ -0,0 +1,69 @@
+'use strict';


settings.ts

fbricon · 2019-01-30T05:48:44Z

you also need to hide .factorypath

fbricon · 2019-01-30T05:55:50Z

if your settings contains

    "files.exclude": {
        "**/.classpath": true,
        "**/.settings": true
    }

agreeing to hide the project settings will change the settings to

    "files.exclude": {
        "**/.project": true
    }

yaohaizh · 2019-01-30T07:00:20Z

For setting generated, if user choose the workspace or global, the settings is split. Should we always keep them the same place? I would let the user to make the decision here.

Signed-off-by: vscjava <[email protected]>

yaohaizh · 2019-01-30T07:29:54Z

@fbricon Updated

fbricon · 2019-01-30T20:37:30Z

How about we change the choices to

Exclude globally
Exclude in workspace
Never

If files exclusions exists in the workspace preferences, then we don't propose to "Exclude globally"

fbricon · 2019-01-30T20:43:30Z

src/settings.ts

+		let needUpdate = false;
+		for (const hiddenFiles of DEFAULT_HIDDEN_FILES) {
+			if (!excludedValue.hasOwnProperty(hiddenFiles)) {
+				needExcludeFiles[hiddenFiles] = true;


no, this will always store a subset of the files, overriding existing settings.
We do want to merge excludedValue + DEFAULT_HIDDEN_FILES in config.get('exclude')

fbricon · 2019-01-30T20:47:05Z

src/settings.ts

+		if (!params.affectsConfiguration('java')) {
+			return;
+		}
+		let newConfig = getJavaConfiguration();


we want to check that if configuration.excludeProjectSettingsFiles is true, but it was false before, then excludeProjectSettingsFiles should be called.

Be aware that oldConfig is only changed if the "java configuration" changed, so it makes things a bit trickier.

yaohaizh · 2019-01-31T02:08:32Z

How about we change the choices to

Exclude globally

Exclude in workspace

Never

If files exclusions exists in the workspace preferences, then we don't propose to "Exclude globally"

Would keep the term simple and consistent with other messages in the similar situation.

fbricon · 2019-01-31T02:38:35Z

I'm fine with having better labels, but they need to be explicit

into yaohai_dev

yaohaizh · 2019-01-31T15:31:55Z

@fbricon Updated PR.

fbricon · 2019-01-31T16:25:14Z

@yaohaizh I've renamed the new preference to better reflect its role:
java.configuration.checkProjectSettingsExclusions

Signed-off-by: Yaohai Zheng <[email protected]>

Hide java project setting files by default.

Unverified

This user has not yet uploaded their public signing key.

GPG key ID: 2A9EEFF323C2244F

Learn about vigilant mode

33d26eb

Signed-off-by: Yaohai Zheng <[email protected]>

yaohaizh force-pushed the yaohai_dev branch from 7d754b4 to 33d26eb Compare January 25, 2019 04:51

fbricon requested changes Jan 26, 2019

View reviewed changes

yaohaizh force-pushed the yaohai_dev branch from 72fcd54 to b6201c8 Compare January 30, 2019 05:06

Improve UX for changing settings.

60c5e2f

Signed-off-by: Yaohai Zheng <[email protected]>

yaohaizh force-pushed the yaohai_dev branch from b6201c8 to 60c5e2f Compare January 30, 2019 05:11

fbricon requested changes Jan 30, 2019

View reviewed changes

fbricon reviewed Jan 30, 2019

View reviewed changes

src/setting.ts Outdated

@@ -0,0 +1,69 @@

'use strict';

Copy link

Collaborator

fbricon Jan 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settings.ts

Resolve review feedback.

7cb7c9b

Signed-off-by: vscjava <[email protected]>

fbricon reviewed Jan 30, 2019

View reviewed changes

Merge branch 'master' of https://github.com/redhat-developer/vscode-java

bb3c18c

into yaohai_dev

fbricon force-pushed the yaohai_dev branch from d54314d to b73854f Compare January 31, 2019 16:23

fbricon force-pushed the yaohai_dev branch from b73854f to 31947bf Compare January 31, 2019 16:41

Refine change behavior.

c7c94a5

Signed-off-by: Yaohai Zheng <[email protected]>

fbricon force-pushed the yaohai_dev branch from 31947bf to c7c94a5 Compare January 31, 2019 16:49

fbricon approved these changes Jan 31, 2019

View reviewed changes

fbricon merged commit cffba7e into master Jan 31, 2019

yaohaizh deleted the yaohai_dev branch March 19, 2019 02:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide java project setting files by default. #776

Hide java project setting files by default. #776

yaohaizh commented Jan 25, 2019 •

edited

Loading

fbricon left a comment

fbricon Jan 25, 2019

fbricon Jan 26, 2019

fbricon Jan 25, 2019

fbricon Jan 25, 2019

fbricon Jan 25, 2019

fbricon commented Jan 26, 2019

yaohaizh commented Jan 30, 2019 •

edited

Loading

fbricon left a comment

fbricon Jan 30, 2019

fbricon commented Jan 30, 2019

fbricon commented Jan 30, 2019

yaohaizh commented Jan 30, 2019 •

edited

Loading

yaohaizh commented Jan 30, 2019

fbricon commented Jan 30, 2019

fbricon Jan 30, 2019

fbricon Jan 30, 2019

yaohaizh commented Jan 31, 2019 •

edited

Loading

fbricon commented Jan 31, 2019

yaohaizh commented Jan 31, 2019

fbricon commented Jan 31, 2019

		import { getJavaConfiguration } from './utils';


		const DEFAULT_HIIDEN_FILES: string[] = ['/.classpath', '/.project', '**/.settings'];

Hide java project setting files by default. #776

Hide java project setting files by default. #776

Conversation

yaohaizh commented Jan 25, 2019 • edited Loading

fbricon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbricon commented Jan 26, 2019

yaohaizh commented Jan 30, 2019 • edited Loading

fbricon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fbricon commented Jan 30, 2019

fbricon commented Jan 30, 2019

yaohaizh commented Jan 30, 2019 • edited Loading

yaohaizh commented Jan 30, 2019

fbricon commented Jan 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yaohaizh commented Jan 31, 2019 • edited Loading

fbricon commented Jan 31, 2019

yaohaizh commented Jan 31, 2019

fbricon commented Jan 31, 2019

yaohaizh commented Jan 25, 2019 •

edited

Loading

yaohaizh commented Jan 30, 2019 •

edited

Loading

yaohaizh commented Jan 30, 2019 •

edited

Loading

yaohaizh commented Jan 31, 2019 •

edited

Loading