Chore: Upgrade to node18 #2681
Merged
Chore: Upgrade to node18 #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah. Sure. Let me take a look at the tests |
Onokaev
previously approved these changes
Jul 26, 2023
ElinorW
reviewed
Aug 1, 2023
ElinorW
approved these changes
Aug 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades dependencies to avoid incompatible peer dependencies on node > 14.x
Updates pipelines to use node 18.x or 18.16.x
Closes #2670
Notes
Open question, should we add an engines section to package.json to make the supported node version explicit?
Currently this set of dependencies appears to build, run, and test correctly on node v14 - v20
Testing Instructions
There are currently a few tests that are failing, as they are when running on node 14, it's just that now they are detected as the failures are inside async operations, which Jest can't detect and report on properly when running on node 14
@Onokaev are you able to take a look at the test failures we're getting on this PR and address them, I don't have enough context for the AuthenticationWrapper tests