Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade to node18 #2681

Merged
merged 20 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: "14.x"
node-version: '18.x'

- name: Cache npm
uses: actions/cache@v3
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: "14.x"
node-version: '18.x'

- name: Cache node_modules
uses: actions/cache@v3
Expand All @@ -85,7 +85,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: "14.x"
node-version: '18.x'

- name: Cache node_modules
uses: actions/cache@v3
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: "14.x"
node-version: '18.x'

- name: Cache node_modules
uses: actions/cache@v3
Expand Down Expand Up @@ -185,9 +185,9 @@ jobs:
skip_deploy_on_missing_secrets: true
azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_JOLLY_SAND_0AC78C710 }}
repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
action: "upload"
app_location: "/" # App source code path
app_artifact_location: "build" # Built app content directory - optional
action: 'upload'
app_location: '/' # App source code path
app_artifact_location: 'build' # Built app content directory - optional

- name: Set url
run: |
Expand All @@ -204,4 +204,4 @@ jobs:
uses: Azure/[email protected]
with:
azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_JOLLY_SAND_0AC78C710 }}
action: "close"
action: 'close'
22 changes: 15 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ The Graph Explorer is written in [TypeScript](https://www.typescriptlang.org/) a

## Running the explorer locally

Microsoft Graph Explorer is built and developed using node v18.

- `npm install` to install project dependencies. `npm` is installed by default with [Node.js](https://nodejs.org/).
- `npm start` starts the TypeScript compiler in watch mode and the local server. It should open your browser automatically with the Graph Explorer at [http://localhost:3000/](http://localhost:3000).

Expand All @@ -28,23 +30,29 @@ The Graph Explorer is written in [TypeScript](https://www.typescriptlang.org/) a
- `npm run lint` linting your files

## Getting Help & Guides

### Where To Get Support

Are you having any trouble with Micrososft Graph or would you like to request a Graph feature?
* Check the [Microsoft Graph - Microsoft Q&A](https://learn.microsoft.com/en-us/answers/tags/161/ms-graph) and [Microsoft Graph - Stack Overflow](https://stackoverflow.com/questions/tagged/msgraph) which provide solutions to commonly experienced issues and asked questions.

* If there is no similar issue, submit the issue on [Microsoft Q&A](https://learn.microsoft.com/en-us/answers/questions/ask/?displayLabel=Microsoft%20Graph) with the tag "Microsoft Graph" or ask questions on [Stack Overflow](https://stackoverflow.com/questions/ask?tags=msgraph).
- Check the [Microsoft Graph - Microsoft Q&A](https://learn.microsoft.com/en-us/answers/tags/161/ms-graph) and [Microsoft Graph - Stack Overflow](https://stackoverflow.com/questions/tagged/msgraph) which provide solutions to commonly experienced issues and asked questions.

- If there is no similar issue, submit the issue on [Microsoft Q&A](https://learn.microsoft.com/en-us/answers/questions/ask/?displayLabel=Microsoft%20Graph) with the tag "Microsoft Graph" or ask questions on [Stack Overflow](https://stackoverflow.com/questions/ask?tags=msgraph).

* For more information about Microsoft Graph, refer to the [Microsoft Graph Docs](https://learn.microsoft.com/en-us/graph/overview) and [Microsoft Graph REST API Docs](https://learn.microsoft.com/en-us/graph/api/overview?view=graph-rest-1.0).
- For more information about Microsoft Graph, refer to the [Microsoft Graph Docs](https://learn.microsoft.com/en-us/graph/overview) and [Microsoft Graph REST API Docs](https://learn.microsoft.com/en-us/graph/api/overview?view=graph-rest-1.0).

Are you new to Graph Explorer or would like to raise a bug or request a feature?
* Use our [Graph Explorer Getting Started Docs](https://learn.microsoft.com/en-us/graph/graph-explorer/graph-explorer-overview) to get guidance on how to quickly use Graph Explorer.

* Use [https://github.com/microsoftgraph/microsoft-graph-explorer-v4/issues](https://github.com/microsoftgraph/microsoft-graph-explorer-v4/issues) to report Graph Explorer bugs and to suggest new features or enhancements (and ask Graph Explorer related questions).
- Use our [Graph Explorer Getting Started Docs](https://learn.microsoft.com/en-us/graph/graph-explorer/graph-explorer-overview) to get guidance on how to quickly use Graph Explorer.

- Use [https://github.com/microsoftgraph/microsoft-graph-explorer-v4/issues](https://github.com/microsoftgraph/microsoft-graph-explorer-v4/issues) to report Graph Explorer bugs and to suggest new features or enhancements (and ask Graph Explorer related questions).

### Building Apps & Accessing M365 Data
* To simplify your Microsoft Graph app-building experience, use our [Microsoft Graph SDKs]((https://learn.microsoft.com/en-us/graph/sdks/sdks-overview)) and [Microsoft Graph Toolkit (MGT)]((https://learn.microsoft.com/en-us/graph/toolkit/overview)) which provide fully functional and out-of-the-box web components.

* Refer to [Microsoft Graph Quick Start](https://developer.microsoft.com/en-us/graph/quick-start) to get a pre-initialized SDK sample application up and running in less 3 minutes using the language of your choice.
- To simplify your Microsoft Graph app-building experience, use our [Microsoft Graph SDKs](<(https://learn.microsoft.com/en-us/graph/sdks/sdks-overview)>) and [Microsoft Graph Toolkit (MGT)](<(https://learn.microsoft.com/en-us/graph/toolkit/overview)>) which provide fully functional and out-of-the-box web components.

- Refer to [Microsoft Graph Quick Start](https://developer.microsoft.com/en-us/graph/quick-start) to get a pre-initialized SDK sample application up and running in less 3 minutes using the language of your choice.

## Contributing

Please see the [contributing guidelines](CONTRIBUTING.md).
Expand Down
6 changes: 3 additions & 3 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:

- task: NodeTool@0
inputs:
versionSpec: "14.20.x"
versionSpec: "18.16.x"
displayName: "Install Node.js"

- script: |
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: "14.20.x"
versionSpec: "18.16.x"
displayName: "Install npm"

- script: |
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: "14.20.x"
versionSpec: "18.16.x"
displayName: "Install Node.js"

- script: |
Expand Down
4 changes: 3 additions & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
const esModules = ['@ms-ofb', 'ngx-bootstrap', 'lodash-es', '@fluentui'].join('|');
const esModules = ['@ms-ofb', 'ngx-bootstrap', 'lodash-es', '@fluentui'].join(
'|'
);
module.exports = {
collectCoverageFrom: [
'src/**/*.{js,jsx,ts,tsx}',
Expand Down
Loading