Fix nil flag client, and warn about use in future (#4885)

mindersec · Nov 5, 2024 · 45300d5 · 45300d5
1 parent 7e6460a
commit 45300d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/internal/flags/flags.go b/internal/flags/flags.go
@@ -39,6 +39,10 @@ func fromContext(ctx context.Context) openfeature.EvaluationContext {
 
 // Bool provides a simple wrapper around client.Boolean to normalize usage for Minder.
 func Bool(ctx context.Context, client openfeature.IClient, feature Experiment) bool {
+	if client == nil {
+		zerolog.Ctx(ctx).Debug().Str("flag", string(feature)).Msg("Bool called with <nil> client, returning false")
+		return false
+	}
 	ret := client.Boolean(ctx, string(feature), false, fromContext(ctx))
 	// TODO: capture in telemetry records
 	return ret

diff --git a/internal/service/service.go b/internal/service/service.go
@@ -76,7 +76,7 @@ func AllInOneServerService(
 	flags.OpenFeatureProviderFromFlags(ctx, cfg.Flags)
 	featureFlagClient := openfeature.NewClient(cfg.Flags.AppName)
 
-	evt, err := eventer.New(ctx, nil, &cfg.Events)
+	evt, err := eventer.New(ctx, featureFlagClient, &cfg.Events)
 	if err != nil {
 		return fmt.Errorf("unable to setup eventer: %w", err)
 	}