Fix nil flag client, and warn about use in future #4885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When merging #4784, I missed that I needed to update
services.go
to pass the flag client. This led to anil
interface inBool()
and a panic.Change Type
Mark the type of change your PR introduces:
Testing
This shows up real fast as a failure to publish messages when running the server. The panic is caught, but no message is published.
Review Checklist: