Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPutObjectStream is not passing with latest and master minio #718

Closed
vadmeste opened this issue Jun 20, 2017 · 3 comments
Closed

TestPutObjectStream is not passing with latest and master minio #718

vadmeste opened this issue Jun 20, 2017 · 3 comments
Assignees
@vadmeste
Labels
priority: medium
Milestone
Current

Comments

@vadmeste
Copy link
Member

--- FAIL: TestPutObjectStreaming (0.00s)
api_functional_v4_test.go:406: Test 1 Error: The request signature we calculated does not match the signature you provided. Check your key and signing method. minio-go-
testh1owqaacnr26h95qc test-object
@deekoder deekoder added this to the Current milestone Jun 20, 2017
@harshavardhana
Copy link
Member

Passes with play.minio.io:9000 using this PR - #720

go test -v -run TestPutObjectStreaming
=== RUN   TestPutObjectStreaming
--- PASS: TestPutObjectStreaming (0.36s)
PASS
ok  	github.com/minio/minio-go	0.367s

@nitisht nitisht mentioned this issue Jun 21, 2017
Merged
@harshavardhana
Copy link
Member

This is because of

commit 5db1e9f3dd74ecce06cbab1cf1c52930a62a302f
Author: Krishna Srinivas <[email protected]>
Date:   Mon May 15 18:17:02 2017 -0700

    signature: use region from Auth header if server's region not configured (#4329)

harshavardhana added a commit to harshavardhana/minio that referenced this issue Jun 21, 2017
@harshavardhana
sign: StreamingSign should just use region from client.
7ede24e 
This is a fix to make streaming signature to behave
the same as regular signature and presigned signature.

Fixes minio/minio-go#718
@harshavardhana harshavardhana mentioned this issue Jun 21, 2017
Merged
8 tasks
harshavardhana added a commit to harshavardhana/minio that referenced this issue Jun 21, 2017
@harshavardhana
sign: StreamingSign should use region from client.
1a68bea 
This is a fix to make streaming signature to behave
the same as regular signature and presigned signature.

Fixes minio/minio-go#718
@harshavardhana
Copy link
Member

Closing this as its not a bug in minio-go instead a regression on the server side and opening on the server.

harshavardhana added a commit to minio/minio that referenced this issue Jun 21, 2017
@harshavardhana
sign: StreamingSign should use region from client. (#4577)
cec8b23 
This is a fix to make streaming signature to behave
the same as regular signature and presigned signature.

Fixes minio/minio-go#718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadmeste vadmeste

Labels
priority: medium
Projects
None yet
Milestone
Current
Development

No branches or pull requests
3 participants
@vadmeste @harshavardhana @deekoder