Refactor Dockerfile #31
Conversation
nitisht
commented
Jun 21, 2017
nitisht
commented
- Moved all the build activities to Docker build phase. While this makes build slower, run is faster.
- Add directories inside run/ for different modes.
- Refactor Dockerfile to add build processes.
- It is now possible to set versions of various SDKs as well
|
Currently the minio-go tests fail due to minio/minio-go#718 |
buildscripts/mint-deps.sh
Outdated
|
|
||
| # Minimum required versions for various languages | ||
| _init() { | ||
| GO_VERSION="1.7.4" |
buildscripts/py-deps.sh
Outdated
| apt-get install -yq python3-pip | ||
|
|
||
| pip3 install --user -r ${minio_py_sdk_path}requirements.txt && \ | ||
| pip3 install minio==$minio_py_sdk_version |
buildscripts/py-deps.sh
Outdated
| } | ||
|
|
||
| pyMain() { | ||
| installMinioPyDeps |
There was a problem hiding this comment.
chain commands with && so that it exits on first failure
buildscripts/js-deps.sh
Outdated
| # Compile test files | ||
| buildMinioJSTests() { | ||
| npm --prefix $minio_js_sdk_path install --save minio@$minio_js_sdk_version | ||
| npm --prefix $minio_js_sdk_path install |
There was a problem hiding this comment.
indentation off here. Also chain commands with && \
buildscripts/java-deps.sh
Outdated
| javaMain() { | ||
| installMinioJavaDeps | ||
| buildMinioJavaTests | ||
| cleanMinioJavaDeps |
There was a problem hiding this comment.
chain commands with && again - same feedback for the other build scripts as well.
|
addressed review comments. |
buildscripts/mint-deps.sh
Outdated
| MC_VERSION="RELEASE.2017-06-15T03-38-43Z" | ||
| MC_TEST_PATH="/mint/run/core/mc" | ||
|
|
||
| MINIO_JS_SDK_PATH="/mint/run/core/minio-js/" |
There was a problem hiding this comment.
You should either use "/" at the end of all paths or no "/" at the end. It is better to have no "/" so that when using it you can always use
${test_path}/minio.test
Currently the code is like this
${test_path}minio.test
In this form it is expected that test_path has a "/" otherwise it will cause lot more trouble. We should fix this consistently everywhere to avoid future bugs.
|
Readme.md needs update for dockerfile vs dockerfile.dev |
…kes build slower, run is faster. - Add directories inside run/ for different modes. - Refactor Dockerfile to add build processes.
|
Fixed review comments. |
