Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.2.3 doesn't work in the browser #654

Closed
gusajz opened this issue Dec 13, 2017 · 1 comment · Fixed by #656
Closed

Release 3.2.3 doesn't work in the browser #654

gusajz opened this issue Dec 13, 2017 · 1 comment · Fixed by #656
Assignees
Milestone

Comments

@gusajz
Copy link

gusajz commented Dec 13, 2017

Hi,

Release 3.2.3 merged #646 which includes this code:

response.socket.end()

The issue is that socket property is available in node but not in the browser (see https://github.com/substack/http-browserify)

This results in Uncaught TypeError: Cannot read property 'end' of undefined after each call of putObject and getObject.

Thanks!

@krishnasrinivas
Copy link
Contributor

Thanks for letting us know @gusajz we will check what the best way is to fix this.

krishnasrinivas added a commit to krishnasrinivas/minio-js that referenced this issue Dec 13, 2017
krishnasrinivas added a commit to krishnasrinivas/minio-js that referenced this issue Dec 13, 2017
krishnasrinivas added a commit to krishnasrinivas/minio-js that referenced this issue Dec 15, 2017
krishnasrinivas added a commit to krishnasrinivas/minio-js that referenced this issue Dec 18, 2017
krishnasrinivas added a commit to krishnasrinivas/minio-js that referenced this issue Dec 18, 2017
krishnasrinivas added a commit to krishnasrinivas/minio-js that referenced this issue Dec 20, 2017
dingjs pushed a commit to dingjs/minio-js that referenced this issue Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants