Close the socket connection if we don't read from it #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failed |
krishnasrinivas
force-pushed
the
drain-response
branch
from
29fe344 to
c0b60e4
Compare
krishnasrinivas
force-pushed
the
drain-response
branch
from
c0b60e4 to
d818a38
Compare
krishnasrinivas
force-pushed
the
drain-response
branch
3 times, most recently
from
6b93d7f to
419b580
Compare
krishnasrinivas
changed the title
src/main/minio.js
Outdated
| @@ -324,6 +324,9 @@ export class Client { | |||
| if (!isString(region)) { | |||
| throw new TypeError('region should be of type "string"') | |||
| } | |||
| if ((returnResponse !== true) && (returnResponse !== false)) { | |||
There was a problem hiding this comment.
Would typeof returnResponse != 'boolean' be better here?
There was a problem hiding this comment.
We have a functions isBoolean for this purpose.
There was a problem hiding this comment.
Ah yes, will use that
krishnasrinivas
force-pushed
the
drain-response
branch
from
419b580 to
ad0b2e8
Compare
harshavardhana
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #640