Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have tests use non-existing docker image #1154

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

dvaldivia
Copy link
Collaborator

We want to prevent the tests from pulling a docker container from the docker registry, so we want to use the specific version we built in this case, using minio/operator:noop which is an image that doesn't exists on the official registry.

This is temporary while we introduce ghcr.io

Signed-off-by: Daniel Valdivia [email protected]

Alevsk
Alevsk previously approved these changes Jun 3, 2022
@cniackz cniackz self-requested a review June 7, 2022 16:18
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why Add build automation for Helm Chart test is consistently failing with this change?:

Waiting for Operator Pods to come online (2m timeout)
pod/console-6c4b7b5cf9-d477c condition met
timed out waiting for the condition on pods/minio-operator-f4cd5b99d-brjxr
timed out waiting for the condition on pods/minio-operator-f4cd5b99d-zj58n
/home/runner/work/operator/operator/testing/check-helm.sh: cannot kubectl wait --namespace minio-operator --for=condition=ready pod --selector app.kubernetes.io/name=operator --timeout=120s
Deleting cluster "kind" ...
Error: Process completed with exit code 111.

I will try to fix and understand the problem with this test in this PR.

@cniackz
Copy link
Contributor

cniackz commented Jun 7, 2022

I see what we are missing:

$ git diff testing/common.sh
diff --git a/testing/common.sh b/testing/common.sh
index d4f1e63..9aa081b 100644
--- a/testing/common.sh
+++ b/testing/common.sh
@@ -56,7 +56,7 @@ function install_operator() {
   if [ "$1" = "helm" ]; then
 
     echo "Change the version accordingly for image to be found within the cluster"
-    yq -i '.operator.image.tag = "dev"' "${SCRIPT_DIR}/../helm/operator/values.yaml"
+    yq -i '.operator.image.tag = "noop"' "${SCRIPT_DIR}/../helm/operator/values.yaml"
 
     echo "Installing Current Operator via HELM"
     helm install \

Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, now all tests are passing!

@dvaldivia dvaldivia merged commit 7ae1610 into minio:master Jun 7, 2022
@dvaldivia dvaldivia deleted the test-use-nonexisting-image branch June 7, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants