Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have tests use non-existing docker image #1154

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Have tests use non-existing docker image #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions testing/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,16 @@ function install_operator() {

# To compile current branch
echo "Compiling Current Branch Operator"
(cd "${SCRIPT_DIR}/.." && make docker) # will not change your shell's current directory
(cd "${SCRIPT_DIR}/.." && TAG=minio/operator:noop make docker) # will not change your shell's current directory

echo 'start - load compiled image so we can use it later on'
kind load docker-image docker.io/minio/operator:dev
kind load docker-image minio/operator:noop
echo 'end - load compiled image so we can use it later on'

if [ "$1" = "helm" ]; then

echo "Change the version accordingly for image to be found within the cluster"
yq -i '.operator.image.tag = "dev"' "${SCRIPT_DIR}/../helm/operator/values.yaml"
yq -i '.operator.image.tag = "noop"' "${SCRIPT_DIR}/../helm/operator/values.yaml"

echo "Installing Current Operator via HELM"
helm install \
Expand Down
2 changes: 1 addition & 1 deletion testing/dev/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
serviceAccountName: minio-operator
containers:
- name: minio-operator
image: minio/operator:dev
image: minio/operator:noop
imagePullPolicy: IfNotPresent
securityContext:
runAsUser: 1000
Expand Down
4 changes: 2 additions & 2 deletions testing/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
operator:
image:
repository: miniodev/operator
tag: dev
repository: minio/operator
tag: noop
pullPolicy: IfNotPresent
2 changes: 1 addition & 1 deletion testing/tenant/tenant.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ metadata:
namespace: minio-tenant
spec:
log:
image: minio/operator:dev
image: minio/operator:noop