Meteor integration #15376

dandv · 2014-12-16T01:14:44Z

Hey guys,

This PR lets you publish Bootstrap to Atmosphere, the package repository for Meteor.js. Between Meteor's 21k stars and Bootstrap's 75k, we hope to get even more users to both projects.

I've included the Meteor publishing task in Grunt's dist task, and have already published the current version, so there's nothing to do for now.

Best regards,
Dan & a bunch of Meteor 3rd party library maintainers

cvrebert · 2014-12-16T03:43:04Z

Gruntfile.js

+        command: [
+          // Make sure Meteor is installed, per https://meteor.com/install.
+          // The curl'ed script is safe; takes 2 minutes to read source & check.
+          'type meteor >/dev/null 2>&1 || { curl https://install.meteor.com/ | sh; }',


Considering that only the Core Team would ever run this task, I think we can just omit this and instead put a comment about it requiring meteor to be installed.

Moving to .travis.yml so CI tests can include the Meteor integration.

cvrebert · 2014-12-16T03:45:41Z

Gruntfile.js

  // Full distribution task.
-  grunt.registerTask('dist', ['clean:dist', 'dist-css', 'copy:fonts', 'dist-js']);
+  grunt.registerTask('dist', ['clean:dist', 'dist-css', 'copy:fonts', 'dist-js', 'meteor-publish']);


dist is meant for use by regular Bootstrap users, so publishing shouldn't be part of this.

Removed. Where should be the meteorPublish task be included?

Nowhere. But we have a checklist that defines the steps in our release process. We would add grunt meteorPublish to that checklist if this PR gets accepted.

hnrch02 · 2014-12-16T03:45:50Z

I'd rather move the top-level meteor folder to grunt/.

cvrebert · 2014-12-16T03:47:21Z

Gruntfile.js

+      },
+      meteorCleanup: {
+        // remove build files and package.js
+        command: 'rm -rf .build.* versions.json package.js'


Use Grunt's clean task instead?

cvrebert · 2014-12-16T04:08:21Z

@dandv So, you mentioned:

[...] we have pass-through package installation via bower: or npm:

Then, what exactly are the benefits of making Bootstrap a "native" Meteor package?

dandv · 2014-12-16T09:06:24Z

@cvrebert: thanks for the inline comments; I'll address each.

Regarding the benefits of pass-through package installation: we don't have that yet - it is just a proposal under discussion. When/if this happens, the wrapper would be very thin, automatic, and by necessity, too generic.

Some of the main advantages of an integration "straight from the authors" include Meteor-specific customizations (e.g. automatically initializing widgets in newly rendered templates), package-specific tests (such as those included in this PR), and precise control over what goes in the package (we had for example a problem with naive wrappers of Font Awesome that included blindly the source font files).

dandv · 2014-12-16T10:08:57Z

@hnrch02 - moved meteor under grunt. Thanks.

cvrebert · 2014-12-18T05:01:26Z

Some of the main advantages of an integration "straight from the authors" include [...] precise control over what goes in the package (we had for example a problem with naive wrappers of Font Awesome that included blindly the source font files).

bower.json already has that data :-)
(And npm should soon too: #15397)

cvrebert · 2014-12-18T05:18:16Z

.travis.yml

+  # Install meteor
+  - curl https://install.meteor.com | /bin/sh
+  # Install spacejam, Meteor's CI helper
+  - npm install -g spacejam


Hmm, this might screw with our dependency caching. Will have to investigate a bit.

This seems unnecessary since you're already adding spacejam to devDependencies in package.json

dandv · 2014-12-19T01:21:23Z

The two errored builds are because npm install -g spacejam (which fails because of a node issue) was cached. I had since removed that line from .travis.yml. How do we bust the cache?

cvrebert · 2014-12-19T01:28:22Z

Pull request builds by folks outside the Bootstrap Core Team don't use any cache.
Sounds like we need to set Travis to specifically use Node.js v0.10.33 until that Node.js bug gets resolved.

cvrebert · 2014-12-19T01:29:52Z

grunt/meteor/README.md

+
+# Issues
+
+If you encounter a Meteor-related issue while using this package, please CC @dandv when you file it in this repo.


Not clear what "this repo" refers to.

Sending a revamped README in a bit.

cvrebert · 2014-12-19T01:42:28Z

Since you don't seem to be trying to include the .less source files, I assume packaging(/build?) conventions around Less/Sass aren't yet established for Meteor?

dandv · 2014-12-19T02:38:03Z

Since you don't seem to be trying to include the .less source files, I assume packaging(/build?) conventions around Less/Sass aren't yet established for Meteor?

Correct - there's ongoing discussion.

cvrebert · 2014-12-19T02:47:57Z

Okay, so should the ability to use .less be mentioned in the README as another reason to use Nemo64/meteor-bootstrap then?

cvrebert · 2014-12-19T22:03:00Z

Well, I'm personally basically out of nitpicks, but I will echo several other of the first-party package maintainers you've contacted in saying that Meteor/Atmosphere is by far the most-burdensome-to-support package manager I've seen thus far. I encourage y'all to highly prioritize external bower/npm/etc. package support (MeteorCommunity/discussions#1).

mdo · 2014-12-23T03:10:25Z

Dang, this is kind of a lot of stuff to add just for one (more) package manager. My hesitation here is adding this functionality into the project and having no one who actively maintains it on our team. I'm unsure if anyone on @twbs/team has some Meteor experience, but so far it's never come up.

Any thoughts on balancing the code additions with that?

dandv · 2014-12-23T04:33:01Z

Well, the bulk of the Meteor support are the tests, which I thought would make for a solid integration. Out of the 10 changed files, five deal with tests (two sources, then one new dep in package.json, one in .travis.yml, and the Grunt tasks), two are package definition files (can't get around that really), one is a two lines of convenience code (init), then we have a README and a .gitignore change.

I could trim that to just the two package definition files and the Grunt tasks if we want to be extra lean. The Meteor <-> Bootstrap integration is very light by comparison with, say, Sortable. Essentially, the package only lists the .CSS, the .JS, and the Glyphicon fonts in a manifest file. The init code is just to make things extra easy for the developer.

In any case, I'll be active in the open source community for the foreseeable future and will be happy to jump in whenever the Meteor integration needs attention.

cvrebert · 2015-01-23T06:46:57Z

@twbs/team Pinging for more opinions. We should try to come to a decision on this.

cvrebert · 2015-01-23T07:35:58Z

@dandv Based on https://groups.google.com/forum/m/#!topic/meteor-core/DPd6XK4Ow-w , sounds like the Meteor devs are against non-native-Meteor Atmosphere packages, like this would be?

dandv · 2015-01-26T10:19:36Z

@cvrebert The Nov 2014 Google Groups thread is rather old; the current consensus is at percolatestudio/atmosphere#297 (comment). TL;DR - if this PR isn't accepted, it's no big deal; we'll host the integration in the MeteorPackaging repo. Meteor are for Meteor integrations on Atmosphere for non-native-Meteor (i.e. 3rd party) packages like Bootstrap. That's how we have 3000+ packages; only a small percentage of those are Meteor native ones, and most are wrappers (unfortunately often multiple poorly updates wrappers dating from the days before the integration efforts).

mdo · 2015-01-30T00:35:16Z

I think I'm a pass on this unfortunately. It's not something most of us on the Bootstrap team use at this time and as we're trying to keep things super lightweight on our end (especially as we head into v4), this would be a bit of a step in the opposite direction. I understand the usefulness though, and deeply appreciate your level of commitment to this effort. That goes a long way in my book :).

Let us know how we can help put some attention from others on this. We have the Expo resources page, but if this is a separate package, feel free to ask for a tweet or two about this down the line.

<3

dandv added 3 commits November 28, 2014 23:27

Add packaging for Meteor.js, http://meteor.com

c061b85

Simplified integration, made tests pass

987c503

Meteor package without the glyphicons font

7fa05e9

cvrebert reviewed Dec 16, 2014
View reviewed changes

hnrch02 added build meta labels Dec 16, 2014

cvrebert reviewed Dec 16, 2014
View reviewed changes

Address misc. PR comments by @cvrebert

c7c8644

This was referenced Dec 16, 2014

Direct integration, similar to d3, with tests mizzao/meteor-bootstrap-3#14

Closed

Checkboxes and radio not working? html5cat/bootstrap-material-design#3

Closed

One x-editable package to rule them all arillo/meteor-x-editable#1

Open

cvrebert reviewed Dec 18, 2014
View reviewed changes

Remove extra spacejam dep, address more @cvrebert comments

40134ff

dandv closed this Dec 19, 2014

dandv reopened this Dec 19, 2014

cvrebert reviewed Dec 19, 2014
View reviewed changes

dandv added 2 commits December 18, 2014 19:53

Improve Meteor README, add JS init for plugins

e42d3fc

Clarify Meteor Template.rendered example

67144e2

dandv mentioned this pull request Dec 19, 2014

Difference from sacha:spin hckrs/meteor-spin#1

Open

dandv mentioned this pull request Dec 31, 2014

No README for Bootstrap package meteor/meteor#3148

Closed

cvrebert added the feature label Jan 23, 2015

Update to Bootstrap 3.3.2. package*.js points to the Meteor README.

abc16f8

mdo closed this Jan 30, 2015

dandv mentioned this pull request Jan 30, 2015

Official Meteor integration directly from 3rd party libraries MeteorCommunity/discussions#14

Open

splendido mentioned this pull request Jan 31, 2015

Official Meteor integration #15716

Closed

dandv mentioned this pull request Feb 12, 2015

How hard should we try to convince the original library author to accept the PR? MeteorPackaging/discussions#5

Open

splendido mentioned this pull request Feb 12, 2015

Integration level: thinnest/lightest, vs. tests & more MeteorPackaging/discussions#8

Open

cvrebert added the meteor label Feb 2, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meteor integration #15376

Meteor integration #15376

dandv commented Dec 16, 2014

cvrebert Dec 16, 2014

dandv Dec 16, 2014

cvrebert Dec 16, 2014

dandv Dec 16, 2014

cvrebert Dec 18, 2014

hnrch02 commented Dec 16, 2014

cvrebert Dec 16, 2014

cvrebert commented Dec 16, 2014

dandv commented Dec 16, 2014

dandv commented Dec 16, 2014

cvrebert commented Dec 18, 2014

cvrebert Dec 18, 2014

cvrebert Dec 18, 2014

dandv commented Dec 19, 2014

cvrebert commented Dec 19, 2014

cvrebert Dec 19, 2014

dandv Dec 19, 2014

cvrebert commented Dec 19, 2014

dandv commented Dec 19, 2014

cvrebert commented Dec 19, 2014

cvrebert commented Dec 19, 2014

mdo commented Dec 23, 2014

dandv commented Dec 23, 2014

cvrebert commented Jan 23, 2015

cvrebert commented Jan 23, 2015

dandv commented Jan 26, 2015

mdo commented Jan 30, 2015


		# Issues

		If you encounter a Meteor-related issue while using this package, please CC @dandv when you file it in this repo.

Meteor integration #15376

Meteor integration #15376

Conversation

dandv commented Dec 16, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hnrch02 commented Dec 16, 2014

Choose a reason for hiding this comment

cvrebert commented Dec 16, 2014

dandv commented Dec 16, 2014

dandv commented Dec 16, 2014

cvrebert commented Dec 18, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dandv commented Dec 19, 2014

cvrebert commented Dec 19, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cvrebert commented Dec 19, 2014

dandv commented Dec 19, 2014

cvrebert commented Dec 19, 2014

cvrebert commented Dec 19, 2014

mdo commented Dec 23, 2014

dandv commented Dec 23, 2014

cvrebert commented Jan 23, 2015

cvrebert commented Jan 23, 2015

dandv commented Jan 26, 2015

mdo commented Jan 30, 2015