-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple KeyVaults #14
Conversation
Looks pretty cool to me.
Scrolling through
|
Sounds good. If I find some time this week I will come up with an adapted Version (probably still wip, though) |
Signed-off-by: Marius <[email protected]>
73c3933
to
c660ba2
Compare
@fbufler I added your suggestions and finished the refactoring (tests are missing), If you find some time, please have a look :) |
Signed-off-by: Marius <[email protected]>
I'm loving it, awesome work :) |
c932ffe
to
682c9aa
Compare
Coverage Report
|
682c9aa
to
f3b534d
Compare
@fbufler I finally found some time to at least implement some unit tests. To ship the functionality I'd say it's okay to merge now and increase unit test coverage later. If you find some time please have a look and try it out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT :) Awesome work btw
Signed-off-by: Marius <[email protected]>
f3b534d
to
bca7147
Compare
@fbufler it's still very much work in progress, but I wanted to see what you think from a users point of view before continuing.
Fixes: #8