Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple KeyVaults #14

Merged
merged 4 commits into from
May 12, 2023
Merged

Conversation

mkah91
Copy link
Owner

@mkah91 mkah91 commented Apr 6, 2023

@fbufler it's still very much work in progress, but I wanted to see what you think from a users point of view before continuing.

Fixes: #8

@mkah91 mkah91 changed the title First draft of multi vault support Add support for multiple KeyVaults Apr 6, 2023
@fbufler
Copy link
Collaborator

fbufler commented Apr 13, 2023

Looks pretty cool to me.
Some minor things I've found that disturbed my experience a bit.

azkv vaults list let's you select vaults (not sure if thats intended by list, maybe we shoud use a set commands idk.

Scrolling through azkv show or azkv edit is a bit unstructured (search obviously helps a lot)

  • Maybe we could only show the vault name if there are duplicate secret names?
  • Or we put the vault name in front with vault/secret so it's a bit more structured.

@mkah91
Copy link
Owner Author

mkah91 commented Apr 13, 2023

Sounds good. If I find some time this week I will come up with an adapted Version (probably still wip, though)

@mkah91 mkah91 force-pushed the add-support-for-multiple-keyvaults branch from 73c3933 to c660ba2 Compare April 20, 2023 19:46
@mkah91
Copy link
Owner Author

mkah91 commented Apr 20, 2023

@fbufler I added your suggestions and finished the refactoring (tests are missing), If you find some time, please have a look :)

Signed-off-by: Marius <[email protected]>
@fbufler
Copy link
Collaborator

fbufler commented Apr 21, 2023

@fbufler I added your suggestions and finished the refactoring (tests are missing), If you find some time, please have a look :)

I'm loving it, awesome work :)

@mkah91 mkah91 force-pushed the add-support-for-multiple-keyvaults branch 9 times, most recently from c932ffe to 682c9aa Compare April 21, 2023 21:28
Repository owner deleted a comment from github-actions bot Apr 21, 2023
@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
azkv.py10100%1, 3, 6–11, 14–15
decorators.py17170%1–2, 4, 7–10, 12, 15–22, 24
main.py62620%1–2, 4–5, 7–15, 17–18, 21–25, 27–35, 38–39, 43–46, 49–53, 55, 58–62, 64, 67–70, 72, 75–84
client
   __init__.py00100% 
   keyvault_client.py815137%38–39, 42–44, 48, 51–53, 56–57, 60, 63–67, 70–73, 76–77, 79–80, 83–91, 94–99, 101, 104–113
   keyvault_clients.py755329%12–16, 21–25, 29, 32–35, 38–42, 45–47, 49–50, 53–54, 57–68, 71–72, 75, 80, 83, 86–94
   keyvault_secret.py17664%14–16, 19–21
commands
   __init__.py00100% 
   check.py250100% 
   common.py42197%89
   edit.py37781%20–26
   show.py45784%20–26
commands/vaults
   __init__.py00100% 
   add.py16160%1, 3, 5, 8–10, 16–18, 21–27
   login.py10100%1–2, 5–10, 16–17
   main.py33330%1, 3–7, 10–13, 15, 18–21, 23–30, 33–36, 38, 41–44, 46
   remove.py11110%1–2, 5–10, 16, 19–20
   select.py11110%1, 4–5, 8–15
TOTAL49229540% 

@mkah91 mkah91 force-pushed the add-support-for-multiple-keyvaults branch from 682c9aa to f3b534d Compare May 11, 2023 18:21
@mkah91 mkah91 marked this pull request as ready for review May 11, 2023 18:25
@mkah91 mkah91 requested a review from fbufler May 11, 2023 18:25
@mkah91
Copy link
Owner Author

mkah91 commented May 11, 2023

@fbufler I finally found some time to at least implement some unit tests. To ship the functionality I'd say it's okay to merge now and increase unit test coverage later. If you find some time please have a look and try it out :)

@mkah91 mkah91 added the enhancement New feature or request label May 11, 2023
Copy link
Collaborator

@fbufler fbufler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT :) Awesome work btw

cli/commands/vaults/common.py Outdated Show resolved Hide resolved
@mkah91 mkah91 force-pushed the add-support-for-multiple-keyvaults branch from f3b534d to bca7147 Compare May 12, 2023 04:57
@mkah91 mkah91 merged commit 1f0ac95 into main May 12, 2023
@mkah91 mkah91 deleted the add-support-for-multiple-keyvaults branch May 12, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple keyvault urls to be used
2 participants