Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for Vault Commands #26

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

mkah91
Copy link
Owner

@mkah91 mkah91 commented Jun 29, 2023

No description provided.

@mkah91 mkah91 added the bug Something isn't working label Jun 29, 2023
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
azkv.py10100%1, 3, 6–11, 14–15
decorators.py17170%1–2, 4, 7–10, 12, 15–22, 24
main.py62620%1–2, 4–5, 7–15, 17–18, 21–25, 27–35, 38–39, 43–46, 49–53, 55, 58–62, 64, 67–70, 72, 75–84
client
   __init__.py00100% 
   keyvault_client.py815137%38–39, 42–44, 48, 51–53, 56–57, 60, 63–67, 70–73, 76–77, 79–80, 83–91, 94–99, 101, 104–113
   keyvault_clients.py755329%12–16, 21–25, 29, 32–35, 38–42, 45–47, 49–50, 53–54, 57–68, 71–72, 75, 80, 83, 86–94
   keyvault_secret.py17664%14–16, 19–21
commands
   __init__.py00100% 
   check.py250100% 
   common.py42197%89
   edit.py37781%20–26
   show.py45784%20–26
commands/vaults
   __init__.py00100% 
   add.py180100% 
   login.py130100% 
   main.py50500%1, 3–7, 10–13, 15–20, 23–26, 28–37, 40–43, 45–50, 53–56, 58–63
   remove.py130100% 
   select.py11372%10–12
TOTAL51626748% 

@mkah91 mkah91 requested a review from fbufler June 29, 2023 20:10
@mkah91 mkah91 changed the title Add unit test and fix bugs Add Unit Tests for Vault Commands Jun 29, 2023
Copy link
Collaborator

@fbufler fbufler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor improvement, else LGTM

cli/commands/vaults/add.py Show resolved Hide resolved
@mkah91 mkah91 merged commit 65c29cc into main Jul 14, 2023
@mkah91 mkah91 deleted the add-unit-tests-for-vault-commands branch July 14, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants