Allow for configurable Tx Size and ex-Units #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
klntsky
suggested changes
Dec 15, 2022
klntsky
reviewed
Dec 15, 2022
jy14898
reviewed
Dec 16, 2022
rynoV
reviewed
Dec 18, 2022
plutip-server/Types.hs
Outdated
Comment on lines
103
to
111
| data StartClusterRequest = | ||
| StartClusterRequest { keysToGenerate :: [[Lovelace]] } -- | Lovelace amounts for each UTXO of each wallet | ||
| | StartClusterRequestWithConfig | ||
| { slotLength :: NominalDiffTime | ||
| , epochSize :: EpochSize | ||
| , maxTxSize :: Natural | ||
| , increasedExUnits :: Bool | ||
| , keysToGenerate :: [[Lovelace]] | ||
| } |
There was a problem hiding this comment.
Would it be possible to change this to be one constructor, and make it so that any keys that are missing from the request (or are set to Nothing) are given default values? This would simplify things for users, as currently if they want to change one of these values they have to supply values for all of them. It would also simplify (in my opinion) the design in your other PR (see my review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.