Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plutip core #169

Merged
merged 22 commits into from
Feb 17, 2023
Merged

Plutip core #169

merged 22 commits into from
Feb 17, 2023

Conversation

zmrocze
Copy link
Contributor

@zmrocze zmrocze commented Jan 15, 2023

Strip down plutip to plutip-core

This change leaves plutip as a tool for spawning local clusters,
removing all the testing functionalities for testing contracts.

  • remove functionality to run test contracts
  • sync deps to cardano-node-1.35.4
  • remove BPI and plutus-apps from deps
  • remove setup for BPI from cluster setup
  • refactor cluster setup
  • new: withCluster (previously withPlutusInterface), withFundedCluster
  • change module structure

  • Update Changelog
  • Format
  • Update docs
  • Refactor nix

This change leaves plutip as a tool for spawning local clusters,
removing all the testing functionalities for testing contracts.

 - remove functionality to run test contracts
 - sync deps to cardano-node-1.35.4
 - remove BPI and plutus-apps from deps
 - remove setup for BPI from cluster setup
 - refactor cluster setup
 - new: withCluster (previously withPlutusInterface), withFundedCluster
 - change module structure
@zmrocze
Copy link
Contributor Author

zmrocze commented Jan 19, 2023

Specifically changes to plutip-server:

  • fix reporting NegativeLovelace (previously this failed too early in json parsing)
  • remove handling of PlutipServerError as it was never thrown
  • Add configurable ex units (merged Allow for configurable Tx Size and ex-Units #165) CTL needs to update ClusterStartupParameters!!

Good improvement would be to report in ClusterStartupFailureReason a case when wallet funding fails due to requested utxo distribution not satisfying the minimum Ada requirement. When this happens the cluster raises this exception.

Copy link
Member

@klntsky klntsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Karol! We will handle these comments by ourselves.

src/Plutip/Launch/PoolConfigs.hs Outdated Show resolved Hide resolved
src/Plutip/Launch/Cluster.hs Show resolved Hide resolved
src/Plutip/Launch/Cluster.hs Outdated Show resolved Hide resolved
src/Plutip/DistributeFunds.hs Show resolved Hide resolved
src/Plutip/Cluster.hs Outdated Show resolved Hide resolved
src/Plutip/Cluster.hs Show resolved Hide resolved
@klntsky klntsky dismissed their stale review February 17, 2023 10:12

addressed

@klntsky klntsky merged commit ff67337 into mlabs-haskell:for-ctl Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants